798794 - Followup on bug 795654 - Artwork appears to be coming out pixelated or patched in stub installer

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Jason Smith [:jsmith]]

Upon trying to install firefox nightly with the stub installer, I noticed that a lot of artwork is coming out pixelated and patch-like. Examples:

- Firefox Nightly on the stub installer came out pixelated
* http://screencast.com/t/TSXhviGd
- Arrow icons are pixelated with white pieces showing
* http://screencast.com/t/VdJkVwi5

We should clean this up to make the artwork look polished.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot

Some additional detail as to your graphic settings would be helpful. I am seeing this.

Comment 3

[Dave Townsend [:mossop]]

Attachment: intro screenshot

Here is what I see for the intro screen.

Comment 4

[Dave Townsend [:mossop]]

Attachment: downloading screenshot

And the downloading screen

Comment 5

[Robert Strong (they/them - no direct email)]

Dave, can you give the details asked for in comment #2?

Comment 6

[Dave Townsend [:mossop]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #5)
> Dave, can you give the details asked for in comment #2?

This looks to be a DPI scaling issue. I run with DPI at 125% (claims to be the default but maybe that's because of my screen size). With the option "Use Windows XP style DPI scaling" which is apparently the default in Vista and above in certain screen sizes, the jagged edges are there. Turning that off gives smoother edges though some of the text is a little blurry.

My main screen size is 1920x1200, my secondary screen runs at 1600x900

Comment 7

[Robert Strong (they/them - no direct email)]

Awesome and thanks for the info

Comment 8

[Robert Strong (they/them - no direct email)]

Increasing the size of the images and scaling down solves this for me so I've requested artwork to fix this.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: stub.exe test

If anyone experiencing this bug could try this out and report back their findings I'd appreciate it. Thanks

Comment 10

[Jason Smith [:jsmith]]

(In reply to Robert Strong [:rstrong] (do not email) from comment #9)
> Created attachment 669338 [details]
> stub.exe test
> 
> If anyone experiencing this bug could try this out and report back their
> findings I'd appreciate it. Thanks

Tried this out on my machine that was having this bug. This worked for me in that I did not get pixelated or patch-like "Firefox Nightly" wording, the images looked polished and not patch-like as I've seen on other machines.

In short - looks good!

Comment 11

[Robert Strong (they/them - no direct email)]

Cool and thanks!

I noticed that some of the images had variances in the color at the larger sizes so I am going to wait on shorlander to provide new images which won't likely happen until sometime Wednesday since he is on vacation.

Comment 12

[Vladan Djeric (:vladan)]

(In reply to Robert Strong [:rstrong] (do not email) from comment #9)
> Created attachment 669338 [details]
> stub.exe test
> 
> If anyone experiencing this bug could try this out and report back their
> findings I'd appreciate it. Thanks

Tried this myself on my Win7 machine with 3 monitors.. it fixes the pixelation!

Comment 13

[Jason Smith [:jsmith]]

I think this is already known, but just in case if this isn't - this bug also affects the Aurora build of the stub installer. So it isn't just Nightly-specific.

Comment 14

[Robert Strong (they/them - no direct email)]

Attachment: new artwork rev1

It is time for some binary patch reviewing ;)

Comment 15

[Robert Strong (they/them - no direct email)]

Attachment: patch - change dialog unit size to accommodate new artwork

The images are likely larger than needed and we will revisit this when we have more breathing room. The way the code is written the images were already resized to fit the control and this change is only needed because additional padding of the image was required to add the fade from the main image color to the background color to prevent the jagged edges.

Comment 16

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/30555cdf10e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a03b8cbcc6

The release artwork still needs to be checked with different DPI settings and I'll do that today when I have a chance.

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/30555cdf10e5
https://hg.mozilla.org/mozilla-central/rev/a0a03b8cbcc6

Comment 18

[Jason Smith [:jsmith]]

Verified on Nightly 10/12.

Comment 19

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e74bb1ef08f
https://hg.mozilla.org/releases/mozilla-aurora/rev/7e4667059308