798874 - The variables view should be filterable

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Required/overlapping with bug 794823. After this, bug 793375 should be trivial.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

This works. Needs a test.
The ugly (?) thing is that it does add a searchbox inside the variables view, but this is only temporary (bug 793375).

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v2

Added tests. Going through try.

Comment 3

[Victor Porof [:vporof][:vp]]

Haha, this fails on debug builds with

TEST-UNEXPECTED-FAIL | The fifth inner property displayed should be 'Location' - Got TraceMallocDumpAllocations, expected Location

Damn debug scope pollution :)

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v3

This should do it.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v4

https://tbpl.mozilla.org/?tree=Try&rev=1881a8f07759

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 675980 [details] [diff] [review]
v4

Sorry Panos :)

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 675980 [details] [diff] [review]
v4

Review of attachment 675980 [details] [diff] [review]:
-----------------------------------------------------------------

+1, <3, Like!

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/72a2dbd8fdd0

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/72a2dbd8fdd0