If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Avoid using gPrivateBrowsingUI.privateBrowsingEnabled in browser.js and use the per-window PB API instead

RESOLVED FIXED in Firefox 19

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 19
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 668952 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #668952 - Flags: review?(josh)

Comment 2

5 years ago
Comment on attachment 668952 [details] [diff] [review]
Patch (v1)

Review of attachment 668952 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this is applied on top of a patch that adds a PrivateBrowsingUtils.jsm import, since MXR shows none.
Attachment #668952 - Flags: review?(josh) → review+
(In reply to comment #2)
> Comment on attachment 668952 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=668952
> Patch (v1)
> 
> Review of attachment 668952 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me assuming this is applied on top of a patch that adds a
> PrivateBrowsingUtils.jsm import, since MXR shows none.

Yep, that's bug 798516.
(which is awaiting your review ;)
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa5fa35e15df

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fa5fa35e15df
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.