Closed
Bug 798965
Opened 12 years ago
Closed 12 years ago
Avoid using gPrivateBrowsingUI.privateBrowsingEnabled in browser.js and use the per-window PB API instead
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 668952 [details] [diff] [review]
Patch (v1)
Review of attachment 668952 [details] [diff] [review]:
-----------------------------------------------------------------
r=me assuming this is applied on top of a patch that adds a PrivateBrowsingUtils.jsm import, since MXR shows none.
Attachment #668952 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to comment #2)
> Comment on attachment 668952 [details] [diff] [review]
> --> https://bugzilla.mozilla.org/attachment.cgi?id=668952
> Patch (v1)
>
> Review of attachment 668952 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=me assuming this is applied on top of a patch that adds a
> PrivateBrowsingUtils.jsm import, since MXR shows none.
Yep, that's bug 798516.
|
|
Assignee | |
Comment 4•12 years ago
|
||
(which is awaiting your review ;)
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•