Closed Bug 798965 Opened 11 years ago Closed 11 years ago

Avoid using gPrivateBrowsingUI.privateBrowsingEnabled in browser.js and use the per-window PB API instead

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 19

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Patch (v1)
1.66 KB, patch
jdm
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch (v1) — — Splinter Review 
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #668952 -
        Flags: review?(josh)

    
    

    
  
Comment on attachment 668952 [details] [diff] [review]
Patch (v1)

Review of attachment 668952 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this is applied on top of a patch that adds a PrivateBrowsingUtils.jsm import, since MXR shows none.

        Attachment #668952 -
        Flags: review?(josh) → review+

    
    

    
  
(In reply to comment #2)
> Comment on attachment 668952 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=668952
> Patch (v1)
> 
> Review of attachment 668952 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me assuming this is applied on top of a patch that adds a
> PrivateBrowsingUtils.jsm import, since MXR shows none.

Yep, that's bug 798516.

    
    

    
  
(which is awaiting your review ;)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fa5fa35e15df
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

          You need to log in
          before you can comment on or make changes to this bug.