799014 - Revisit browser-social code that moves the panel to keep the anchor arrow aligned.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

If a panel with an arrow on the right is resized, the right hand size of the panel moves meaning the arrow is mis-aligned.  browser-social.js has code to work around this (search for this bug number) - that should be removed once the underlying panel platform issue is resolved.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is bug 798226 the panel platform issue?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #1)
> Is bug 798226 the panel platform issue?

Sure is.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Cleanup social's anchor related code

This patch is on top of the patches in bug 798226 and bug 822165.  It will almost certainly change as the patches in those 2 bugs evolve.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Use moveToAnchor and resize the panel directly

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 748604 [details] [diff] [review]
Use moveToAnchor and resize the panel directly

sweet!

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96abf4e7f53e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/96abf4e7f53e