Last Comment Bug 799434 - Earlybird builds shouldn't have profiling enabled
: Earlybird builds shouldn't have profiling enabled
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on: 799295
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-09 02:59 PDT by Mark Banner (:standard8)
Modified: 2012-11-28 13:04 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed


Attachments
Fix for beta (4.76 KB, patch)
2012-11-28 12:49 PST, Mark Banner (:standard8)
nthomas: review+
standard8: approval‑comm‑beta+
Details | Diff | Review
Fix for aurora (2.67 KB, patch)
2012-11-28 12:51 PST, Mark Banner (:standard8)
nthomas: review+
standard8: approval‑comm‑aurora+
Details | Diff | Review

Description Mark Banner (:standard8) 2012-10-09 02:59:47 PDT
It was never intended to have profiling on Earlybird builds, this was missed in the last merge, we should remove --enable-profiling from the aurora mozconfigs.

I'm not going to do this until bug 799295 is fixed though, as there may be a crash issue lurking with profiling disabled.
Comment 1 Mark Banner (:standard8) 2012-10-09 03:31:34 PDT
Fixed the merge scripts for future merges:

http://hg.mozilla.org/users/bugzilla_standard8.plus.com/drivertools/rev/14971748f97c
Comment 2 Mark Banner (:standard8) 2012-11-28 12:49:53 PST
Created attachment 686232 [details] [diff] [review]
Fix for beta

Remove the profiling option for beta.
Comment 3 Mark Banner (:standard8) 2012-11-28 12:51:08 PST
Created attachment 686233 [details] [diff] [review]
Fix for aurora

The fix for the automatic merge scripts, didn't take care of the l10n-mozconfig files. I'll fix the script in a bit, but here's the patch to fully fix aurora.
Comment 4 Mark Banner (:standard8) 2012-11-28 12:54:21 PST
Additional fix for the merge scripts for aurora:

http://hg.mozilla.org/users/bugzilla_standard8.plus.com/drivertools/rev/07edaa01509c
Comment 5 Mark Banner (:standard8) 2012-11-28 12:57:41 PST
https://hg.mozilla.org/releases/comm-beta/rev/fa1a33021313
Comment 6 Mark Banner (:standard8) 2012-11-28 13:03:49 PST
Comment on attachment 686233 [details] [diff] [review]
Fix for aurora

[Triage Comment]
Comment 7 Mark Banner (:standard8) 2012-11-28 13:04:16 PST
https://hg.mozilla.org/releases/comm-aurora/rev/1137787ef611

Note You need to log in before you can comment on or make changes to this bug.