Closed Bug 799434 Opened 13 years ago Closed 13 years ago

Earlybird builds shouldn't have profiling enabled

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird18+ fixed, thunderbird19+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
thunderbird18 + fixed
thunderbird19 + fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Fix for beta
4.76 KB, patch
nthomas
: review+
standard8
: approval-comm-beta+
Details | Diff | Splinter Review
Fix for aurora
2.67 KB, patch
nthomas
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review
It was never intended to have profiling on Earlybird builds, this was missed in the last merge, we should remove --enable-profiling from the aurora mozconfigs. I'm not going to do this until bug 799295 is fixed though, as there may be a crash issue lurking with profiling disabled.
Attached patch Fix for beta — — Splinter Review
Remove the profiling option for beta.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #686232 - Flags: review?(nthomas)
Attached patch Fix for aurora — — Splinter Review
The fix for the automatic merge scripts, didn't take care of the l10n-mozconfig files. I'll fix the script in a bit, but here's the patch to fully fix aurora.
Attachment #686233 - Flags: review?(nthomas)
Attachment #686232 - Flags: review?(nthomas) → review+
Attachment #686233 - Flags: review?(nthomas) → review+
Attachment #686232 - Flags: approval-comm-beta+
Comment on attachment 686233 [details] [diff] [review] Fix for aurora [Triage Comment]
Attachment #686233 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/1137787ef611
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status-thunderbird19: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: