Closed Bug 799498 Opened 13 years ago Closed 13 years ago

[responsive mode] Disable floating scrollbars

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox18 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox18 --- fixed

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(1 file)

v1
4.02 KB, patch
past
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
See bug 799471.
Summary: [responsive mode] Disable floating toolbar → [responsive mode] Disable floating scrollbars
Attached patch v1 — — Splinter Review
Comment on attachment 669542 [details] [diff] [review] v1 We need to disable the floating scrollbars because of bug 799471. I also think these are the reason why we ran into race conditions in bug 798775 bug 798772 and bug 797335. This patch re-introduce the 2 tests and disable the floating scrollbars.
Attachment #669542 - Flags: review?(past)
Comment on attachment 669542 [details] [diff] [review] v1 Review of attachment 669542 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine. I assume you will be adding the toggle (checkbox, pref, or whatever) in bug 799471?
Attachment #669542 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #4) > I assume you will be adding the toggle (checkbox, pref, or > whatever) in bug 799471? Indeed.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4d3652c0a96f
Assignee: nobody → paul
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 19
Comment on attachment 669542 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 752850 User impact if declined: performance problem Testing completed (on m-c, etc.): fx-team / m-c Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: no
Attachment #669542 - Flags: approval-mozilla-aurora?
Comment on attachment 669542 [details] [diff] [review] v1 Approving for aurora as its a low risk patch and will help avoid performance problems on the user side.
Attachment #669542 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: