799549 - PlacesUtils.jsm should not be loaded in B2G

Status: RESOLVED DUPLICATE of bug 799536

(Firefox OS Graveyard :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

│  │  │  ├─────192,920 B (00.28%) -- compartment([System Principal], resource://gre/modules/PlacesUtils.jsm)

Places is disabled in B2G.

Comment 1

[Justin Lebar (not reading bugmail)]

We're also opening a Places SQLite db for another 300kb.

│   ├────337,816 B (00.49%) -- places.sqlite

That may or may not end up being a separate bug.

Comment 2

[Justin Lebar (not reading bugmail)]

PlacesUtils.jsm appears to be imported by sync/util.js, so maybe this is a dupe of bug 799536.  I'll respin and see.

Comment 3

[[:fabrice] Fabrice Desré]

(In reply to Justin Lebar [:jlebar] from comment #0)
> 
> Places is disabled in B2G.

I don't think places is disabled, since we need it for visited links coloring. In firefox for android they re-implemented a custom history store (https://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsAndroidHistory.h) to really disable places.

Comment 4

[Justin Lebar (not reading bugmail)]

> I don't think places is disabled, since we need it for visited links coloring.

Indeed, you're right!

Comment 5

[Justin Lebar (not reading bugmail)]

(In reply to Justin Lebar [:jlebar] from comment #4)
> > I don't think places is disabled, since we need it for visited links coloring.
> 
> Indeed, you're right!

And PlacesUtils.jsm went away after I nuked the sync stuff, so this is a dupe of bug 799536.  Great!

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I thought we disabled global history?

If not, do let's!

Comment 7

[Justin Lebar (not reading bugmail)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> I thought we disabled global history?
> 
> If not, do let's!

Filed bug 799609.