Sync services are running on b2g

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug)

unspecified
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I see e.g.

│  │  │  ├──────83,096 B (00.12%) -- compartment([System Principal], resource://services-sync/identity.js)

These compartments don't appear to be taking up a ton of memory, but we definitely should turn them off.  It's also possible they're using more memory than we think, due to message-manager overhead (i.e., these or other scripts could be causing bug 7980020).
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Updated

5 years ago
blocking-basecamp: --- → ?
(Assignee)

Updated

5 years ago
Whiteboard: [MemShrink]
(Assignee)

Comment 1

5 years ago
> (i.e., these or other scripts could be causing bug 7980020).

bug 798002.

That sync is running appears to be intentional.  in b2g/confvars.sh, we have:

> MOZ_SERVICES_SYNC=1

I thought we weren't using sync in b2g v1?
(Assignee)

Comment 2

5 years ago
Created attachment 669599 [details] [diff] [review]
Patch, v1
Attachment #669599 - Flags: review?(jones.chris.g)
Attachment #669599 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eaac88ab86d
(Assignee)

Updated

5 years ago
Duplicate of this bug: 799549
Apparently we're not doing sync in v1.
blocking-basecamp: ? → +
(Assignee)

Comment 6

5 years ago
I'll land in Aurora once I get some greenage on m-i.
https://hg.mozilla.org/mozilla-central/rev/0eaac88ab86d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/08abc3599a33

We don't currently have bugzilla flags to indicate fixed-on-aurora, but we'll have them on Thursday.
This change breaks Marionette because we use log4moz.js.
Comment on attachment 669599 [details] [diff] [review]
Patch, v1

Review of attachment 669599 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/confvars.sh
@@ +16,5 @@
>  MOZ_OFFICIAL_BRANDING_DIRECTORY=b2g/branding/official
>  # MOZ_APP_DISPLAYNAME is set by branding/configure.sh
>  
>  MOZ_SAFE_BROWSING=
> +MOZ_SERVICES_SYNC=

For future reference, you should just delete the variable wholesale.
Depends on: 800154
(Assignee)

Comment 11

5 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #9)
> This change breaks Marionette because we use log4moz.js.

Not to be glib, but it seems like a bug in Marionette that it relies on a module from sync.

Anyway, I'm happy for you to back this out while you fix Marionette, so long as you'll put it back in once the dependency is resolved.
(Assignee)

Comment 12

5 years ago
> For future reference, you should just delete the variable wholesale.

Should I also delete the other variables?  Or are there circumstances where "FOO=" is the right thing to do?
Marionette does not rely on Sync. There are toolkit-like files in service/common (like log4moz.js) that Marionette relies on. The build system isn't smart enough to differentiate between services/common and services/sync. I'll code that up in bug 800154.

(In reply to Justin Lebar [:jlebar] from comment #12)
> > For future reference, you should just delete the variable wholesale.
> 
> Should I also delete the other variables?  Or are there circumstances where
> "FOO=" is the right thing to do?

It's a style thing. The default value for an unknown variable is undefined. It's safer to just not define a variable than to define one with an empty value, IMO.
(Assignee)

Updated

5 years ago
status-firefox18: --- → fixed
status-firefox19: --- → fixed
You need to log in before you can comment on or make changes to this bug.