799605 - Mirror mozbase -> m-c for bug 799288 and bug 799507

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

These bugs are currently blocking mochitest and reftest automation in b2g.

https://github.com/mozilla/mozbase/compare/mozilla-central...HEAD

Comment 1

[Jeff Hammel]

Attachment: c84d6da5669d9846719dac6e001348786b010874

Comment 2

[Jeff Hammel]

This needs to be tested, somehow

Comment 3

[William Lachance (:wlach)]

Comment on attachment 669667 [details] [diff] [review]
c84d6da5669d9846719dac6e001348786b010874

Review of attachment 669667 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Andrew Halberstadt [:ahal]]

We'll probably want to do a full try run due to the mozprocess change (which should also cover DM changes on fennec). For B2G I'll apply the patch on the desktop reftest machine. The b2g reftests are currently broken, but applying this patch to a clean m-c should fix them.

Comment 5

[Jeff Hammel]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5f29c1a65692

Comment 6

[Jeff Hammel]

failure because of https://bugzilla.mozilla.org/show_bug.cgi?id=799681 ; retrying

Comment 7

[Jeff Hammel]

Attachment: 36a2f63be33af799a54d7f1511dc922730b10b22

Comment 8

[William Lachance (:wlach)]

Comment on attachment 669734 [details] [diff] [review]
36a2f63be33af799a54d7f1511dc922730b10b22

ok

Comment 9

[Jeff Hammel]

pushed to try (again): https://tbpl.mozilla.org/?tree=Try&rev=438af9190775

Comment 10

[Jeff Hammel]

looks good, pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a7e188cc3e

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c0a7e188cc3e

Comment 12

[Jeff Hammel]

tagged: https://github.com/mozilla/mozbase/zipball/mozilla-central

Comment 13

[Jonathan Griffin (:jgriffin)]

Comment on attachment 669734 [details] [diff] [review]
36a2f63be33af799a54d7f1511dc922730b10b22

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: This is test code needed to be able to run mochitest and other unittests on B2G in aurora.  No user impact.
Testing completed (on m-c, etc.): Green on m-c.
Risk to taking this patch (and alternatives if risky): It is possible, but very unlikely, that this could break desktop test harnesses on aurora, in which case it would be backed out.
String or UUID changes made by this patch: N/A

Comment 14

[bhavana bajaj [:bajaj]]

Comment on attachment 669734 [details] [diff] [review]
36a2f63be33af799a54d7f1511dc922730b10b22

Approving. Please make sure to keep an eye on this check-in & a= bajaj if it needs to be backed out

Comment 15

[Jonathan Griffin (:jgriffin)]

This bug didn't have a valid resolved type, so I couldn't make changes to it without reopening it and re-fixing it.

Comment 16

[Jonathan Griffin (:jgriffin)]

Landed on aurora as https://hg.mozilla.org/releases/mozilla-aurora/rev/d5fd58f26db5, will watch the tree for breakage.