Closed
Bug 799632
Opened 12 years ago
Closed 12 years ago
Add a pref to control automatic download of updates
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 19
People
(Reporter: snorp, Assigned: snorp)
References
Details
(Keywords: productwanted)
Attachments
(1 file, 1 obsolete file)
19.73 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
There should be a preference to control the automatic download policy for updates on Nightly/Aurora. Right now we always automatically download when on wifi, and never for mobile data. We probably want a "wifi, never, always" sort of option.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → snorp
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #670406 -
Flags: review?(sriram)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #670419 -
Flags: review?(sriram)
Assignee | ||
Updated•12 years ago
|
Attachment #670406 -
Attachment is obsolete: true
Attachment #670406 -
Flags: review?(sriram)
Assignee | ||
Updated•12 years ago
|
Attachment #670419 -
Flags: review?(sriram) → review?(bnicholson)
Comment 3•12 years ago
|
||
Comment on attachment 670419 [details] [diff] [review] Add a preference for controlling automatic update downloads on Android Review of attachment 670419 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/resources/xml/preferences.xml.in @@ -108,5 @@ > android:negativeButtonText="@string/button_cancel" > android:persistent="false" /> > > </PreferenceCategory> > - nit: I'd leave this space here.
Attachment #670419 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7009f7377d85
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7009f7377d85
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Comment 6•12 years ago
|
||
Build ID: 19.0 (2012-10-16) Nightly Channel Device: Samsung Galaxy Nexus OS: Android 4.1 Now in settings are Automatic updates and you can choose: - only over Wi-Fi - disabled - enabled Setting the bug to Verified Fixed.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Flags: in-moztrap?(ioana.chiorean)
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 670419 [details] [diff] [review] Add a preference for controlling automatic update downloads on Android [Approval Request Comment] Not sure if we want this or not. Low risk, but adds strings.
Attachment #670419 -
Flags: approval-mozilla-beta?
Attachment #670419 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Keywords: productwanted
Comment 8•12 years ago
|
||
Given that we're not tracking this, there's little to suggest we want to uplift - esp. when it breaks string-freeze. Would need a solid case from product drivers including a communication with l10n drivers to go ahead with something like that.
Comment 9•12 years ago
|
||
Comment on attachment 670419 [details] [diff] [review] Add a preference for controlling automatic update downloads on Android removing nomination flags, re-set them if the previous comment's criteria are met
Attachment #670419 -
Flags: approval-mozilla-beta?
Attachment #670419 -
Flags: approval-mozilla-aurora?
Comment 10•12 years ago
|
||
I definitely just got a "downloading update" notification on 3G in a restaurant while this option in Settings shows "Automatic Updates: disabled". This would be two bugs actually: - updates over 3G, while not on Wifi (bug 793276) - update check even when setting says otherwise (this bug) 20121024 Nightly build, HTC One V on 4.0.3 (**** phone - 512MB RAM, 1GHz single-core resulting in terrible Firefox experience)
Assignee | ||
Comment 11•12 years ago
|
||
(In reply to Thomas Stache from comment #10) > I definitely just got a "downloading update" notification on 3G in a > restaurant while this option in Settings shows "Automatic Updates: > disabled". This would be two bugs actually: > - updates over 3G, while not on Wifi (bug 793276) > - update check even when setting says otherwise (this bug) > Filed 805431, and I think I know the issue > 20121024 Nightly build, HTC One V on 4.0.3 (**** phone - 512MB RAM, 1GHz > single-core resulting in terrible Firefox experience) It should run ok on that device. What sort of issue are you seeing (besides this updater one).
Comment 12•12 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #11) > > 20121024 Nightly build, HTC One V on 4.0.3 (**** phone - 512MB RAM, 1GHz > > single-core resulting in terrible Firefox experience) > > It should run ok on that device. What sort of issue are you seeing (besides > this updater one). (OT for this bug, sorry) Mainly speed issues - startup (and resume) feels like >10seconds, about:home and awesomescreen init really tiring. I just hope Lucas' patches will help. Going back is slooow, doesn't really feel like serving from cache (or even BFCache!). And Nightly get's killed way too easily by the OS, which emphasizes the above issues. Chrome doesn't fare much better though, seems like modern apps and ICS need 1GB RAM.
Comment 13•11 years ago
|
||
TCs were added in MozTrap for Firefox 19, Firefox 19 tablets, Firefox 20, Firefox 20 tablets in Settings Suite: https://moztrap.mozilla.org/manage/cases/?filter-suite=68 (at the beginning of December but I forgot to comment here) https://moztrap.mozilla.org/manage/case/5872/ Automatic updates - default option https://moztrap.mozilla.org/manage/case/5871/ Automatic updates menu
Flags: in-moztrap?(ioana.chiorean) → in-moztrap+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•