The default bug view has changed. See this FAQ.

Current comm-central builds of GData extension use old and incorrect version 0.2pre

RESOLVED FIXED in 2.1

Status

Calendar
Provider: GData
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Stefan Sitter, Assigned: Fallen)

Tracking

Lightning 2.1
Dependency tree / graph

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Todays comm-central build of the of GData extension based on mozilla19 source code will identify itself as version 0.2pre.

Version 0.2 of the GData extension was already released in 2007. Current version number should be higher ;)
(Assignee)

Comment 1

5 years ago
Created attachment 670914 [details] [diff] [review]
Fix - v1

Looks like this kind of bug is biting me everywhere :) This patch should fix it, at least until 0.100 ;-)
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #670914 - Flags: review?(ssitter)
(Reporter)

Updated

5 years ago
Attachment #670914 - Flags: review?(ssitter) → review+
(Assignee)

Comment 2

5 years ago
Pushed to comm-central changeset 7f1a33a6e03b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1
(Reporter)

Comment 3

5 years ago
Somehow it didn't work on the Linux build server. The install.rdf file contains only 
<em:version></em:version> without any version information. The Mac OS X build seems OK.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

5 years ago
Blocks: 803981
(In reply to Stefan Sitter from comment #3)
> Somehow it didn't work on the Linux build server. The install.rdf file
> contains only 
> <em:version></em:version> without any version information. The Mac OS X
> build seems OK.

Yes, to be precise: both L32 and L64 builds lack the version information. The Mac build has <em:version>0.20pre</em:version> as expected. No W32 build was produced (the latest one was on 18 October), which is of course a different bug.
This reminds me of a change I've seen in another file: http://hg.mozilla.org/hgcustom/hghooks/rev/e7d2ca6c9aee#l1.28

What is the Python version of the linux builders?
Depends on: 803834
(Assignee)

Comment 6

5 years ago
Mac uses python 2.7 since the new slave is around, Linux uses 2.6 since today and 2.5 before, Windows uses 2.7 since today and 2.5 before.
(In reply to Philipp Kewisch [:Fallen] from comment #6)
> Mac uses python 2.7 since the new slave is around, Linux uses 2.6 since
> today and 2.5 before, Windows uses 2.7 since today and 2.5 before.

So Linux builders are on an older version than the rest. See also bug 803834 comment #3.
(Reporter)

Comment 8

5 years ago
Philipp, could you provide a patch that works with Python 2.6? As long as this version is supported by the build system we should support it too.
(Assignee)

Comment 9

5 years ago
Created attachment 677709 [details] [diff] [review]
Additional Fix

I've tested this with python 2.6 and 2.7, it should work.
Attachment #677709 - Flags: review?(ssitter)
Attachment #677709 - Flags: approval-calendar-beta?
Attachment #677709 - Flags: approval-calendar-aurora?
(Reporter)

Comment 10

5 years ago
Comment on attachment 677709 [details] [diff] [review]
Additional Fix

The original problem and its patch were only checked in to comm-central (Lightning 2.1) therefore I see no need to port it back to aurora and beta.
Attachment #677709 - Flags: review?(ssitter) → review+
(Assignee)

Comment 11

5 years ago
Comment on attachment 677709 [details] [diff] [review]
Additional Fix

Oh, right. Thanks for the reminder!
Attachment #677709 - Flags: approval-calendar-beta?
Attachment #677709 - Flags: approval-calendar-aurora?
(Assignee)

Comment 12

5 years ago
Pushed to comm-central changeset f919289ef9c8
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.