799929 - Downloads Panel item icons are practically invisible on OSX.

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Hard-to-see icons

The icons are white on a gray background, making them very difficult to see.

See screenshot. That can't be right.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Current icon set

Here's the current icon set. I think we need something darker. Or, alternatively, we need to make the panel background significantly darker to make the lighter icons visible (though I somehow doubt this is the approach we'll take).

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Cc'ing and needinfo'ing shorlander re: icons.

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to Mike Conley (:mconley) from comment #1)
> Created attachment 669953 [details]
> Current icon set
> 
> Here's the current icon set. I think we need something darker. Or,
> alternatively, we need to make the panel background significantly darker to
> make the lighter icons visible (though I somehow doubt this is the approach
> we'll take).

Yeah these are the old icons from when the panel was still dark. I will make darker icons.

Comment 4

[Marco Bonardo [:mak]]

we basically need all the icons for all the OSes, the current ones must be considered placeholders.

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [:mak] from comment #4)
> we basically need all the icons for all the OSes, the current ones must be
> considered placeholders.

They shouldn't be considered placeholders. They were just updated recently.

Comment 6

[Marco Bonardo [:mak]]

From what I remember Paolo used some personally edited icon where they were missing, dunno if you consider that an update, or there was another bug I missed...

Comment 7

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [:mak] from comment #6)
> From what I remember Paolo used some personally edited icon where they were
> missing, dunno if you consider that an update, or there was another bug I
> missed...

Paolo put the new ones I gave him in the last patch of Bug 760607 I think :)

Comment 8

[:Paolo Amadini]

(In reply to Stephen Horlander from comment #7)
> Paolo put the new ones I gave him in the last patch of Bug 760607 I think :)

Hm, Stephen, when I landed the patch I asked you if the icons were still visible
on the white background... you lied ;-)

Seriously, the new icons landed basically at the same time as the change of
panel background, so this was kind of a known issue, though I expected the
icons to be more visible than the screenshot shows.

We might consider quick "invert" on the PNG while we wait for the final icons.

Comment 9

[Stephen Horlander [:shorlander]]

(In reply to Paolo Amadini [:paolo] from comment #8)
> (In reply to Stephen Horlander from comment #7)
> > Paolo put the new ones I gave him in the last patch of Bug 760607 I think :)
> 
> Hm, Stephen, when I landed the patch I asked you if the icons were still
> visible
> on the white background... you lied ;-)

I think I said they were kind of visible ;)

Comment 10

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons for Light Panels - i01

Updated icons for new light panels.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Binary diff to replace the original buttons.png.

I'll throw up a screenshot or two and then r?.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Attachment: Cancel icon, not hovered.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: Restart download icon, not hovered

Hovering over these swaps in the darker icon, and click-holding gives us the blue icons, as expected.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Attachment: Questionable visibility when downloaded item is hovered

I notice that for completed downloads, hovered download items have a blue background. The dark icons on that blue background are difficult to see.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 670131 [details] [diff] [review]
Patch v1

Stephen:

I know you said that I just needed r+ on this, but the background-is-blue-on-hover thing makes me wonder if we should do one of the following:

1) Not change the background colour of a downloaded item to blue on hover
2) Swap out the icon for a fourth one - a lighter one - when the item is hovered. This would necessitate several new icons.

How should it appear?

-Mike

Comment 16

[:Paolo Amadini]

We do have a fourth row of inverted "open in folder" icons on Windows XP and
sometimes on Vista, for that specific case.

While we're here, let's confirm that we're not going to reduce the hovering area
again in the short term, as suggested in bug 787285 (I'm experimenting with the
new needinfo flag to ask for Stephen's feedback on that).

Comment 17

[Marco Bonardo [:mak]]

we can fix the icons when bug 787285 will be fixed, I don't feel like that's a blocker so we could just think about it later.

Comment 18

[Stephen Horlander [:shorlander]]

(In reply to Paolo Amadini [:paolo] from comment #16)
> We do have a fourth row of inverted "open in folder" icons on Windows XP and
> sometimes on Vista, for that specific case.
> 
> While we're here, let's confirm that we're not going to reduce the hovering
> area
> again in the short term, as suggested in bug 787285 (I'm experimenting with
> the
> new needinfo flag to ask for Stephen's feedback on that).

The brighter blue color was actually supposed to be for a selected state that we don't have :) I don't know that we even need a hover state on OSX but if we keep then it should be something more subtle.

In regards to bug 787285 I don't think the solution, if one is required, will be to go back to the clipped item area.

Comment 19

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons for Light Panels - i02

Combined the new icons and the inverted icons for the hover state.

Comment 20

[Stephen Horlander [:shorlander]]

Attachment: Download Panel Icons for Light Panels - i03

Actually until we change the hover state we will only need the inverted hover icons. So I just inserted one column of the dark icons.

Comment 21

[Stephen Horlander [:shorlander]]

Comment on attachment 670131 [details] [diff] [review]
Patch v1

Sorry, I should have included the inverted icons with the updated dark icons. Until we figure out the entire hover state appearance it just needs to use the dark icons in the non-hover state.

Comment 22

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

This patch does the following:

- Eliminates the downloadCancel and downloadRetry hover / active rules on OSX until bug 787285 is resolved.
- Uses the light icons for downloadShow when hovering the download item. The hover and active states still work for this button, but this all might be academic if we end up moving that button outside of the hoverable-download-item area.

So, basically, this is a visibility stopgap for OSX until bug 787285 gets sorted out.

Comment 23

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 670444 [details] [diff] [review]
Patch v2

Got the thumbs up from shorlander over IRC, so clearing ui-r?.

Comment 24

[Marco Bonardo [:mak]]

Comment on attachment 670444 [details] [diff] [review]
Patch v2

Review of attachment 670444 [details] [diff] [review]:
-----------------------------------------------------------------

<3 academic patches

Comment 25

[Mike Conley (:mconley) (:⚙️)]

Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/64bf0d8480a5

Comment 26

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/64bf0d8480a5