OrangeFactor should adjust 'es_server' automatically if testing the client-side from the local filesystem

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This is OrangeFactor's equivalent of bug 799908.

Currently we can test client-side only changes by running index.html from the local filesystem & pointing the UI at the production server-side components. However this requires changing es_server in woo.config.js every time I want to test locally. 

I do this by popping/pushing an mq, but it's still a PITA to have to remember to do - and if I forget to push the mq before starting the next patch, I inevitably end up at some point qrefreshing parts of the patch into my baseURL mq patch.

We should just detect "file:" in window.location.protocol and set the value automatically to save this messing about.
(Assignee)

Comment 1

6 years ago
Created attachment 669971 [details] [diff] [review]
Patch v1

Happy to adjust the wording (or line wrapping of the ternary) if needed :-)
Attachment #669971 - Flags: review?(mcote)

Comment 2

6 years ago
Comment on attachment 669971 [details] [diff] [review]
Patch v1

Review of attachment 669971 [details] [diff] [review]:
-----------------------------------------------------------------

Very cool! I suppose eventually we'll want to change this to point to our dev server when it's up, but good for now.
Attachment #669971 - Flags: review?(mcote) → review+
(Assignee)

Comment 3

6 years ago
Cheers :-)

https://hg.mozilla.org/automation/orangefactor/rev/b408e761bd66
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Testing → Tree Management
You need to log in before you can comment on or make changes to this bug.