Don't hard code the contact photos in cardDialog

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Address Book
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 19.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The default Contact photos in cardDialog are hard coded in XUL and JS. This makes it impossible to add HiDPI images for Retina Macs and themers have to follow this name and path to show the images.
(Assignee)

Comment 1

5 years ago
Created attachment 670116 [details] [diff] [review]
patch

I gave the menulist the value="default" and made the CSS selector matching this to be nice to Add-ons which add more default icons (Display Contact Photo).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #670116 - Flags: review?(mconley)
Attachment #670116 - Attachment is patch: true
(Assignee)

Comment 2

5 years ago
Created attachment 670770 [details] [diff] [review]
patch v2

Oops, forgot the changes in addressbook.css which made the default photo not showing in AB.
Attachment #670116 - Attachment is obsolete: true
Attachment #670116 - Flags: review?(mconley)
Attachment #670770 - Flags: review?(mconley)
Comment on attachment 670770 [details] [diff] [review]
patch v2

Review of attachment 670770 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the wait! This looks good - I just think we should update a comment.

Thanks,

-Mike

::: mail/components/addrbook/content/abCommon.js
@@ +16,5 @@
>  const kDefaultDescending = "descending";
>  const kLdapUrlPrefix = "moz-abldapdirectory://";
>  const kPersonalAddressbookURI = "moz-abmdbdirectory://abook.mab";
>  const kCollectedAddressbookURI = "moz-abmdbdirectory://history.mab";
>  // The default image for contacts

Let's update this comment so that it says,

// The default, generic contact image is displayed via CSS when the photoURI is
// blank.
Attachment #670770 - Flags: review?(mconley) → review+

Updated

5 years ago
Blocks: 360488
(Assignee)

Comment 4

5 years ago
Created attachment 674022 [details] [diff] [review]
patch for check-in

Patch addressing the review comment.

carrying over r+
Attachment #670770 - Attachment is obsolete: true
Attachment #674022 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5fe67c22b3e5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.