Closed Bug 800123 Opened 8 years ago Closed 8 years ago

Don't hard code the contact photos in cardDialog

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 19.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

The default Contact photos in cardDialog are hard coded in XUL and JS. This makes it impossible to add HiDPI images for Retina Macs and themers have to follow this name and path to show the images.
Attached patch patch (obsolete) — Splinter Review
I gave the menulist the value="default" and made the CSS selector matching this to be nice to Add-ons which add more default icons (Display Contact Photo).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #670116 - Flags: review?(mconley)
Attachment #670116 - Attachment is patch: true
Attached patch patch v2 (obsolete) — Splinter Review
Oops, forgot the changes in addressbook.css which made the default photo not showing in AB.
Attachment #670116 - Attachment is obsolete: true
Attachment #670116 - Flags: review?(mconley)
Attachment #670770 - Flags: review?(mconley)
Comment on attachment 670770 [details] [diff] [review]
patch v2

Review of attachment 670770 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the wait! This looks good - I just think we should update a comment.

Thanks,

-Mike

::: mail/components/addrbook/content/abCommon.js
@@ +16,5 @@
>  const kDefaultDescending = "descending";
>  const kLdapUrlPrefix = "moz-abldapdirectory://";
>  const kPersonalAddressbookURI = "moz-abmdbdirectory://abook.mab";
>  const kCollectedAddressbookURI = "moz-abmdbdirectory://history.mab";
>  // The default image for contacts

Let's update this comment so that it says,

// The default, generic contact image is displayed via CSS when the photoURI is
// blank.
Attachment #670770 - Flags: review?(mconley) → review+
Blocks: TB2SM
Patch addressing the review comment.

carrying over r+
Attachment #670770 - Attachment is obsolete: true
Attachment #674022 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5fe67c22b3e5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.