Last Comment Bug 800123 - Don't hard code the contact photos in cardDialog
: Don't hard code the contact photos in cardDialog
Product: Thunderbird
Classification: Client Software
Component: Address Book (show other bugs)
: unspecified
: All All
-- normal (vote)
: Thunderbird 19.0
Assigned To: Richard Marti (:Paenglab)
Depends on:
Blocks: TB2SM
  Show dependency treegraph
Reported: 2012-10-10 13:41 PDT by Richard Marti (:Paenglab)
Modified: 2013-01-04 12:10 PST (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (4.36 KB, patch)
2012-10-10 13:47 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Splinter Review
patch v2 (6.82 KB, patch)
2012-10-12 05:18 PDT, Richard Marti (:Paenglab)
mconley: review+
Details | Diff | Splinter Review
patch for check-in (6.94 KB, patch)
2012-10-22 14:38 PDT, Richard Marti (:Paenglab)
richard.marti: review+
Details | Diff | Splinter Review

Description User image Richard Marti (:Paenglab) 2012-10-10 13:41:34 PDT
The default Contact photos in cardDialog are hard coded in XUL and JS. This makes it impossible to add HiDPI images for Retina Macs and themers have to follow this name and path to show the images.
Comment 1 User image Richard Marti (:Paenglab) 2012-10-10 13:47:55 PDT
Created attachment 670116 [details] [diff] [review]

I gave the menulist the value="default" and made the CSS selector matching this to be nice to Add-ons which add more default icons (Display Contact Photo).
Comment 2 User image Richard Marti (:Paenglab) 2012-10-12 05:18:02 PDT
Created attachment 670770 [details] [diff] [review]
patch v2

Oops, forgot the changes in addressbook.css which made the default photo not showing in AB.
Comment 3 User image Mike Conley (:mconley) 2012-10-22 12:43:20 PDT
Comment on attachment 670770 [details] [diff] [review]
patch v2

Review of attachment 670770 [details] [diff] [review]:

Sorry for the wait! This looks good - I just think we should update a comment.



::: mail/components/addrbook/content/abCommon.js
@@ +16,5 @@
>  const kDefaultDescending = "descending";
>  const kLdapUrlPrefix = "moz-abldapdirectory://";
>  const kPersonalAddressbookURI = "moz-abmdbdirectory://abook.mab";
>  const kCollectedAddressbookURI = "moz-abmdbdirectory://history.mab";
>  // The default image for contacts

Let's update this comment so that it says,

// The default, generic contact image is displayed via CSS when the photoURI is
// blank.
Comment 4 User image Richard Marti (:Paenglab) 2012-10-22 14:38:04 PDT
Created attachment 674022 [details] [diff] [review]
patch for check-in

Patch addressing the review comment.

carrying over r+
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-10-22 16:55:01 PDT

Note You need to log in before you can comment on or make changes to this bug.