800235 - Uploading and playing ogg videos doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gregor Wagner [:gwagner]]

I downloaded: http://en.wikipedia.org/wiki/File:Big_Buck_Bunny_Trailer_400p.ogg
and pushed it to the device.

When I start the music app I see:

E/GeckoConsole(  668): Content JS WARN at app://music.gaiamobile.org/shared/js/mediadb.js:1203 in metadataError: MediaDB: error parsing metadata for Movies/123.ogg : malformed ogg comment packet
E/GeckoConsole(  668): Content JS WARN at app://music.gaiamobile.org/shared/js/mediadb.js:1203 in metadataError: MediaDB: error parsing metadata for Movies/123.ogg : Error: advance past end of buffer

I verified that I can play the file again if I download it from the card.

Comment 1

[Andrew Overholt [:overholt]]

David Clarke, can you help see if this is reproducible?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Andrew Overholt [:overholt] from comment #1)
> David Clarke, can you help see if this is reproducible?

QA Contact, not assignee for QA btw.

Comment 3

[[e-mail] [:onecyrenus]]

This is in fact reproducible, but I think possibly this is a gaia bug, possibly in the mediaDB.js.

If we are unable to parse the metadata, we don't allow the file to be played. 

That looks like what is happening here, my recommend would be to create this as a gaia bug.

Comment 4

[[e-mail] [:onecyrenus]]

dflanagan can probably tell the exact issue, or i can dig in, if further clarification is needed.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I tried to play the ogg on desktop and it says the file is corrupt.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oops.  ignore comment 5.  must have been a bad download.  I was able to play the ogg video just fine.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

- Ogg video doesn't show in the video app... 
- music app is finding the videos and saying it's an unknown type.

We should probably split this into two bugs?

Comment 9

[Dietrich Ayala (:dietrich)]

Assigning to Dale for the video part. Dale, can you file a new separate bug for the Music app problem, and assign to Dominic?

Comment 10

[Andrew Overholt [:overholt]]

Will the camera be able to record ogg video?

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

No

Comment 12

[Andrew Overholt [:overholt]]

Should we just not support ogv, then?

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We can't do that.

Is the problem here that the hard-coded file extensions in mediastorage are classifying a .ogg video as audio?

Comment 14

[Doug Turner (:dougt)]

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/devicestorage.properties?force=1

ogg is just audio

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Can we sniff files that are ambiguous?  Don't we have this problem with mp4 too?

Comment 16

[cajbir (:cajbir)]

Generally .oga and .ogg is for ogg audio, .ogv for video. See RFC 5334:

http://xiph.org/ogg/doc/rfc5334.txt

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Do we have evidence that .ogg videos are very uncommon?

Comment 18

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I thought that we had mechanics to support autodetecting mimetypes only when loading files locally. I.e. some sort of concept of a "weak" mimetype indication.

Or does our audio/video code generally not do any sniffing in any situations?

Comment 19

[Dale Harvey (:daleharvey)]

Attachment: Bug 800235 - Add .ogg to valid video file extensions. r=dougt

Comment 20

[Dale Harvey (:daleharvey)]

With ogg files recognised as videos and this PR https://github.com/mozilla-b2g/gaia/pull/5970

.ogg videos play fine, audio .ogg files are always recognised as video/ogg however we can check a videoWidth property to check if actual video is present

The crash in the Music app is doing exactly as its supposed to, we might want to clean up the actual error thats thrown, however it is correctly refusing to play Video ogg files.

Comment 21

[David Flanagan [:djf]]

r- on the gaia patch, but it should be easy to fix. See my comments on github.

Dale, in the future, please attach a dummy file on bugzilla to point to github, and request review here. As we've transitioned to bugzilla, I haven't been keeping up with review requests on github.

Note that we've got a similar issue with .mp4 files, which can be audio or video. See https://github.com/mozilla-b2g/gaia/issues/5872 which probably needs to be converted to a bugzilla bug.

Comment 22

[Dale Harvey (:daleharvey)]

Cheers David, I fixed up the patch, and I will make sure to get the bugzilla review thing fixed for next time.

Comment 23

[Dale Harvey (:daleharvey)]

and as a note this should fix mp4 audio files as well, updated the commit message / comments to reflect that

Comment 24

[Dale Harvey (:daleharvey)]

Attachment: Add check to make sure audio files with video/ content types are not confused with videos

Comment 25

[David Flanagan [:djf]]

Comment on attachment 675092 [details]
Add check to make sure audio files with video/ content types are not confused with videos

A couple of optional nits to consider on github, but overall looks good.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df8e5da6e69f

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df8e5da6e69f

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/15d6d97a9b5d