Closed
Bug 800281
Opened 13 years ago
Closed 13 years ago
Remove usage of MozWebSocket in FrameWorker.jsm
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: jaws, Assigned: ananuti)
Details
(Whiteboard: [good first bug][mentor=jaws][lang=js])
Attachments
(1 file)
|
1.46 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Starting in Gecko 11, MozWebSocket was unprefixed and should just be referenced as WebSocket.
We should remove the reference to MozWebSocket in FrameWorker.jsm in this array,
> let workerAPI = ['MozWebSocket', 'WebSocket', 'localStorage',
> 'atob', 'btoa', 'clearInterval', 'clearTimeout', 'dump',
> 'setInterval', 'setTimeout', 'XMLHttpRequest',
> 'MozBlobBuilder', 'FileReader', 'Blob',
> 'location'];
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/social/FrameWorker.jsm#99
|
Assignee | |
Comment 1•13 years ago
|
||
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 670676 [details] [diff] [review]
patch
Review of attachment 670676 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me!
Attachment #670676 -
Flags: review?(jaws) → review+
|
|
Reporter | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
I verified there is no reason to keep MozWebSocket in the worker.
|
||
Comment 4•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•