Remove usage of MozWebSocket in FrameWorker.jsm

RESOLVED FIXED in Firefox 19

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: Ekanan Ketunuti)

Tracking

Trunk
Firefox 19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jaws][lang=js])

Attachments

(1 attachment)

Starting in Gecko 11, MozWebSocket was unprefixed and should just be referenced as WebSocket.

We should remove the reference to MozWebSocket in FrameWorker.jsm in this array,
> let workerAPI = ['MozWebSocket', 'WebSocket', 'localStorage',
>                  'atob', 'btoa', 'clearInterval', 'clearTimeout', 'dump',
>                  'setInterval', 'setTimeout', 'XMLHttpRequest',
>                  'MozBlobBuilder', 'FileReader', 'Blob',
>                  'location'];

https://mxr.mozilla.org/mozilla-central/source/toolkit/components/social/FrameWorker.jsm#99
(Assignee)

Comment 1

5 years ago
Created attachment 670676 [details] [diff] [review]
patch
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #670676 - Flags: review?(jaws)
Comment on attachment 670676 [details] [diff] [review]
patch

Review of attachment 670676 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #670676 - Flags: review?(jaws) → review+
Keywords: checkin-needed
I verified there is no reason to keep MozWebSocket in the worker.
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaffa9d2341e
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eaffa9d2341e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.