800345 - [HiDPI] icons for the preferences window

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: icons v1.0

8 icons for your viewing / reviewing pleasure.

Derek, if you have energy to test this, please nitpick in particular on the window used in the Web Features icon as that window is reused in various other icons.
(also, PrefPanes are bundles, right-click-view-package-contents on each)

---

[1] when a small (24x24) image is available in the existing image set, I generated the equivalent @2x file, for the sake of completeness. When none exist(ed), I didn’t bother… those 24x24 images are not accessible from the Camino UI anyway. They are only used by the Finder in Icon view and Cover Flow when viewing the Prefpanes, depending on the size of the icons as set in the Finder prefs. (the average user won’t go diving inside the Camino bundle)


[2] the General prefpane reuses the Apple provided image as a stopgap measure pending resolution of bug 769123. And I simply resized the 32x32@2x bitmap to 24x24@2x in Photoshop… sosumi.

Comment 1

[philippe (part-time)]

Attachment: screenshot v1.0

Comment 2

[Derek Schrock]

Comment on attachment 670373 [details]
icons v1.0

Appearance.tiff - Looks good 
 side note: Is there any reason why it's ABC instead of RGB?

Downloads.tiff - The point seems bulky. Maybe cut a pixel or two off the two sides of the point?  Since it's so dark it almost looks like it's part of the shadow.

General.tiff - N/A.

History.tiff - Now that you have a triangular-like hour/minute hand it seems there should be a 12 hour marker like the 3/6/9 marks.  Also, the hour (short) hand seems darker and not symmetric when compared to the minute (longer) hand.  I like the minute hand so I think the hour should be lighter and symmetric. 

Privacy.tiff - The left side of the loop seems a little to thick when compared to the right.  Seems it be one pixel off?

Security.tiff - Looks good.

Tabs.tiff - Looks good however should the x be darker so it matches the non-mouse-over close tab x?

WebFeatures.tiff - If possible can there be any more detail given to the close/min/max buttons?  Should the bottom be grey so it matches the current Camino style window? Also, the bottom left and right corners seems they should be more round or as round as the upper left and right.

Comment 3

[philippe (part-time)]

Attachment: icons-v1.01

(In reply to Derek Schrock from comment #2)
 
> Appearance.tiff - Looks good 
>  side note: Is there any reason why it's ABC instead of RGB?

Because the pref pane covers ‘font & text’ and ‘colors’ ? IOW, the ‘abc’ stands for text. At least,that is how I understand it.
 
> Downloads.tiff - The point seems bulky. Maybe cut a pixel or two off the two
> sides of the point?  Since it's so dark it almost looks like it's part of
> the shadow.

OK, reworked completely, using a narrow border. How does it stack up now ?
(I made that one long time ago, and was initially wary about using such tinny borders, but looking through the Apple made images available on 10.8, many use tinny borders / lines – much more than what was available on 10.7)

> History.tiff - Now that you have a triangular-like hour/minute hand it seems
> there should be a 12 hour marker like the 3/6/9 marks.  Also, the hour
> (short) hand seems darker and not symmetric when compared to the minute
> (longer) hand.  I like the minute hand so I think the hour should be lighter
> and symmetric.

I tried adding a marker for the 12o’clock point, but that didn’t look good at all (the glossy glass reflection in the north-north-west quarter makes the top of the minutes arm look lighter; there is no difference in color with the marker anymore).

It looks like this: http://dev.l-c-n.com/camino/_d/[e-mail]

And yes, there _is_ a reason why product photography for watches always has the time set to 10:12
Here is an alternative (need some more polish love) following that line:
http://dev.l-c-n.com/camino/_d/[e-mail]

The image in the v1.01 package doesn’t include a marker at the 12 point, I think I’ve addressed you other points.

There is another possible workaround for that marker issue: add markers for every hour (with the 2/6/9/12 markers slightly more prominent). I' use rectangles instead of squares, though. The 12o'clock marker wouldn't be visible (masked by the arm).

BTW the existing icons have the hour hand slightly wrong (it points to 4:30), the @2x icon has it set correctly (as does the icon in the BM manager); the Time machine icon has the same problem…
 
> Privacy.tiff - The left side of the loop seems a little to thick when
> compared to the right.  Seems it be one pixel off?

Tweaked.
 
> Tabs.tiff - Looks good however should the x be darker so it matches the
> non-mouse-over close tab x?

Hmm, the original image has a white x marker, but I’ve tweaked it a little.
 
> WebFeatures.tiff - If possible can there be any more detail given to the
> close/min/max buttons?  Should the bottom be grey so it matches the current
> Camino style window?

Do you mean a status bar ? The original image doesn’t have one (and none of the other icons that reuse the window idea do)

> Also, the bottom left and right corners seems they
> should be more round or as round as the upper left and right.

The upper left and right corners were actually to ‘rounded’ :-) – I’ve reduced the radius of those corners, while slightly increased the radius at the bottom.

I’ve also attempted to improve the traffic lights, they should now match the 10.7+ buttons more closely and look sharper. There aren’t many pixels to add more details though.

Thanks for the feedback!

Comment 4

[philippe (part-time)]

Attachment: screenshot v1.01

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I (still) have no internet at home again and have a lot of other stuff going on, so I have no idea when I'll be able to get to this (and the other stuff outstanding) :-(

Comment 6

[Derek Schrock]

Comment on attachment 670781 [details]
icons-v1.01

(In reply to philippe (part-time) from comment #3)
> Created attachment 670781 [details]
> icons-v1.01
>  
> OK, reworked completely, using a narrow border. How does it stack up now ?
> (I made that one long time ago, and was initially wary about using such
> tinny borders, but looking through the Apple made images available on 10.8,
> many use tinny borders / lines – much more than what was available on 10.7)

Downloads.tiff - The point looks good, however could we get a sample of the icon moved up and outside of the shadow?  It still looks weird with the point being inside the shadow.  So maybe move the arrow up 4 pixels but keep the shadow the same. 

> I tried adding a marker for the 12o’clock point, but that didn’t look good
> at all (the glossy glass reflection in the north-north-west quarter makes
> the top of the minutes arm look lighter; there is no difference in color
> with the marker anymore).
> 
> It looks like this: http://dev.l-c-n.com/camino/_d/[e-mail]
> 
> And yes, there _is_ a reason why product photography for watches always has
> the time set to 10:12
> Here is an alternative (need some more polish love) following that line:
> http://dev.l-c-n.com/camino/_d/[e-mail]
> 
> The image in the v1.01 package doesn’t include a marker at the 12 point, I
> think I’ve addressed you other points.

History.tiff - The icon still looks odd without the 12 marker.  I would agree the icon with the marker does alter the hand only because they're both black.  Do like the 10:12.  I think something needs to be done here.

> 
> There is another possible workaround for that marker issue: add markers for
> every hour (with the 2/6/9/12 markers slightly more prominent). I' use
> rectangles instead of squares, though. The 12o'clock marker wouldn't be
> visible (masked by the arm).
> 
> BTW the existing icons have the hour hand slightly wrong (it points to
> 4:30), the @2x icon has it set correctly (as does the icon in the BM
> manager); the Time machine icon has the same problem…
> The upper left and right corners were actually to ‘rounded’ :-) – I’ve
> reduced the radius of those corners, while slightly increased the radius at
> the bottom.
> 
> I’ve also attempted to improve the traffic lights, they should now match the
> 10.7+ buttons more closely and look sharper. There aren’t many pixels to add
> more details though.

There appears to be enough pixels the new button looks good and the new equally rounded corners look good too.


Appearance.tiff +
General.tiff + 
Privacy.tiff + 
Security.tiff + 
Tabs.tiff + 
WebFeatures.tiff + 

History.tiff -  
Downloads.tiff -

Comment 7

[philippe (part-time)]

(In reply to Derek Schrock from comment #6)
 
> Downloads.tiff - The point looks good, however could we get a sample of the
> icon moved up and outside of the shadow?  It still looks weird with the
> point being inside the shadow.  So maybe move the arrow up 4 pixels but keep
> the shadow the same.

The original low-dpi image has the same position for the tip. It never felt weird to me. For consistencies sake, I'd need to change the low-dpi image as well (*). Anyway, I'll attach a modified hi-dpi image next, with the tip moved up a couple of pixels.

(*) not that much work given that I made the original low-dpi image.

> History.tiff - The icon still looks odd without the 12 marker.  I would
> agree the icon with the marker does alter the hand only because they're both
> black.  Do like the 10:12.  I think something needs to be done here.

Ok, here is option 1 (in line with 'add details to Hi-DPI images'): markers for all hours (and the 12 marker is hidden behind the arm).
Option 2 would change the design of the icon to use the 10:12 idea from comment 3. This implies also remaking the low-dpi image.

sample: http://dev.l-c-n.com/camino/_d/[e-mail]

Comment 8

[philippe (part-time)]

Attachment: alt history and downloads icons

per comment 6 & 7

Comment 9

[philippe (part-time)]

Attachment: screenshot (HiDPI) with alt download and history icons

Comment 10

[philippe (part-time)]

(In reply to philippe (part-time) from comment #7)

> Ok, here is option 1 (in line with 'add details to Hi-DPI images'): markers
> for all hours (and the 12 marker is hidden behind the arm).

And additional argument in favor of option 1: we also have a toolbar icon for history and there is the history_icon in the bookmark manager (HiDPI image already checked). All those would have to be changed to match option 2.

(I'd rather see option 2 something for the future)

Comment 11

[Derek Schrock]

Comment on attachment 671184 [details]
alt history and downloads icons

Agreed, option 1 seems to be the best approach and Downloads.tiff where the arrow is moved up a couple pixels.  Both look good in HiDPI.

Comment 12

[philippe (part-time)]

Attachment: Preferences icons v1.2

OK, I’m glad we reached an agreement :-)

The icons v1.2 archive now uses the History icon with markers at all 12 points, and the alternate Downloads icon – only the HiDPI images have the tip of the arrow slightly above the shadow.
I’ve also included the history toolbar icon which is a carbon copy of the Preferences icon (it is in a separate folder inside the archive).

attachment 671185 [details] is the relevant HiDPI screenshot

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (offline for a while; not following bugs - do not email) from comment #5)
> I (still) have no internet at home again and have a lot of other stuff going
> on, so I have no idea when I'll be able to get to this (and the other stuff
> outstanding) :-(

I won't have internet next week, but I ought to have some down time, so I've saved all the relevant items from this and bug 770809 and will try to review them…