800625 - [unagi][camera] recording video does not show preview

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
Unagi phone, build 2012-10-11 us
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 0d6d050bc37d3167cc82a1885fd7660456bb0f4e
* "gaia" revision= 2667536e3b06e46dd193aa6d76ba08dad2d867be 
* "releases-mozilla-central" revision= c0ea0728044b2a5f9556ca988635140963cff037
* "gonk-misc" revision= 6ec34aa3d66331054de37eabc594ad923654b27c

## Repro :
1. select camera app
2. select video button

## Expected :
1. video shows preview

## Actual :
1. frame freezes

## Note :
1. works fine on 10/11 build of otoro

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

tapping sleep and then unlocking the phone will fix the preview.  It only occurs after switching from camera.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Naoki Hirata :nhirata from comment #3)
> tapping sleep and then unlocking the phone will fix the preview.  It only
> occurs after switching from camera.

I looked into why this works:

After the app gets visible again Camera.startPreview() is called, which then calls Camera.setSource()

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

That should be:

After the app gets visible again Camera.startPreview() is called, which then calls Camera.setSource(). This calls camera.getPreviewStream() instead of camera.getPreviewStreamVideoMode(). Maybe the latter doesn't work at all?

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Stealing.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6003

Pointer to Github pull-request

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 675184 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6003

Without a profile name we should never get a working video stream.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

*Sigh* Trying to switch from the (now working) video back to photo mode just gives a black screen.

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 675184 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6003

Handing off review to dale--he's the JS expert.

Comment 11

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 675184 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6003

Probably better to set the default to 'cif' for now, as Otoro (and possibly Unagi) has some trouble with 'high'--though of course this should be populated from CameraCapabilities.recorderProfiles, and eventually persisted somewhere.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Tim Taubert [:ttaubert] from comment #9)
> *Sigh* Trying to switch from the (now working) video back to photo mode just
> gives a black screen.

I updated the pull request so that switching back from video mode to picture mode works now.

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Mike Habicher [:mikeh] from comment #11)
> Probably better to set the default to 'cif' for now, as Otoro (and possibly
> Unagi) has some trouble with 'high'--though of course this should be
> populated from CameraCapabilities.recorderProfiles, and eventually persisted
> somewhere.

I tried setting 'cif' because that's what 352x288 is but GonkRecorderProfileManager::IsSupported() returns false. That's why I switched to 'high'. But you're right - the 'high' <-> 'cif' mapping might not be the same on other devices.

Comment 14

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Tim Taubert [:ttaubert] from comment #13)
> 
> I tried setting 'cif' because that's what 352x288 is but
> GonkRecorderProfileManager::IsSupported() returns false. That's why I
> switched to 'high'. But you're right - the 'high' <-> 'cif' mapping might
> not be the same on other devices.

There's also a buildtime vs runtime discrepancy that I'm working on as well.  See bug 804359.

Comment 15

[Dale Harvey (:daleharvey)]

Yup the high profile breaks the preview on otoro (and some recent change broke not specifying a profile on otoro as well), cif is working for me on otoro.

So now video recording preview is broken on both devices :) but it looks like this patch will fix both, if we can get the recording profiles picked up from the capabilities then I can test on otoro. the rest of the patch looks great

Cheers

Comment 16

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Dale Harvey (:dale) from comment #15)
> 
> ...if we can get the recording profiles picked
> up from the capabilities then I can test on otoro. the rest of the patch
> looks great

Working on that patch right now.  If you like, just keep passing in 'cif' until the fix for .recorderProfiles is ready.

Comment 17

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Mike Habicher [:mikeh] from comment #16)
> Working on that patch right now.  If you like, just keep passing in 'cif'
> until the fix for .recorderProfiles is ready.

Awesome, thx! Updated the PR to use the 'cif' profile.

Comment 18

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/44f2cd600a5f4845f07f43dc527e9cc23d9374d6

Comment 19

[John Hammink]

Not possible to test on 10/30 build because pressing video button causes preview to freeze.

Comment 20

[John Hammink]

Ok - that was 10/30 STABLE build (with 10/26 gaia).  My bad.

Testing on 10/30 nightly, Unagi phone

gaia - 6e5b7220fb5900023a2e62b7635804f1d5e78472
gecko - cb0d5d5eaa3cdcf2d4b04d0f72eff481b46d1195

Works.