Closed Bug 801080 Opened 13 years ago Closed 13 years ago

window.close will not close social panels

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17+ verified, firefox18+ verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox17 + verified
firefox18 + verified

People

(Reporter: Gavin, Assigned: markh)

References

Details

(Whiteboard: [Fx17])

Attachments

(1 file)

Set nsIDOMWindowUtils.allowScriptsToClose() plus tests
2.94 KB, patch
Felipe
: review+
Gavin
: approval-mozilla-aurora+
Gavin
: approval-mozilla-beta+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #799592 +++ Morphing bug 799592 to cover the core fix. We'll need a social front-end fix to use the new API being introduced there.
Assignee: nobody → mhammond
Attachment #671673 - Flags: review?(jaws)
Attachment #671673 - Flags: review?(jaws) → review+
there was a stray dump() in the test which I removed. https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5f5e60f37c
Attachment #671673 - Flags: approval-mozilla-beta+
Attachment #671673 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/bf5f5e60f37c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
It looks like the patch landing includes tests. Is this correct?
Flags: in-testsuite?
Flags: in-testsuite? → in-testsuite+
Thanks Mark. Verified fixed based on tests.
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
status-firefox18: fixed → verified
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: