window.close will not close social panels

VERIFIED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: markh)

Tracking

unspecified
Firefox 19
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17+ verified, firefox18+ verified)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #799592 +++

Morphing bug 799592 to cover the core fix. We'll need a social front-end fix to use the new API being introduced there.
(Assignee)

Comment 1

5 years ago
Created attachment 671673 [details] [diff] [review]
Set nsIDOMWindowUtils.allowScriptsToClose() plus tests
Assignee: nobody → mhammond
Attachment #671673 - Flags: review?(jaws)
Attachment #671673 - Flags: review?(jaws) → review+
(Assignee)

Comment 2

5 years ago
there was a stray dump() in the test which I removed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5f5e60f37c
Attachment #671673 - Flags: approval-mozilla-beta+
Attachment #671673 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/51f6d986d9cd
https://hg.mozilla.org/releases/mozilla-beta/rev/d1fff984c152
status-firefox17: --- → fixed
status-firefox18: --- → fixed

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bf5f5e60f37c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
It looks like the patch landing includes tests. Is this correct?
Flags: in-testsuite?
(Assignee)

Updated

5 years ago
Flags: in-testsuite? → in-testsuite+
Thanks Mark. Verified fixed based on tests.
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
status-firefox18: fixed → verified
You need to log in before you can comment on or make changes to this bug.