Closed Bug 801819 Opened 7 years ago Closed 7 years ago

Remove nsIDOMCSS2Properties and CSS declaration classinfo bits

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Attachment #671658 - Flags: review?(peterv)
Attachment #671658 - Flags: review?(dbaron)
Whiteboard: [need review]
Comment on attachment 671658 [details] [diff] [review]
Unpref the CSSStyleDeclaration binding.

r=dbaron

Please merge with bug 115199 if it lands first or describe the necessary merging there if it doesn't.
Attachment #671658 - Flags: review?(dbaron) → review+
Thanks for pointing that out.  Looks like the merge should be a no-op, actually, at first glance.  I'll double-check once Peter reviews.
I thought there would be some additional removals since that patch clones CSSFontFaceStyleDecl for another declaration implementation.
It doesn't clone it correctly (leaves out the classinfo, which is the part this bug is removing), but the incorrectness only matters if this pref is flipped.
Comment on attachment 671658 [details] [diff] [review]
Unpref the CSSStyleDeclaration binding.

Review of attachment 671658 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/doc/adding-style-props.html
@@ +458,2 @@
>  <a href="#CSSPropList">add your property</a> to <a href="http://lxr.mozilla.org/seamonkey/source/content/shared/public/nsCSSPropList.h">
> +nsCSSPropList.h</a>. 

Trailing whitespace.
Attachment #671658 - Flags: review?(peterv) → review+
Looks like this actually got unpreffed in bug 801083.
Summary: Unpref CSSStyleDeclaration binding → Remove nsIDOMCSS2Properties and CSS declaration classinfo bits
http://hg.mozilla.org/integration/mozilla-inbound/rev/316f2d6d7cbd
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/316f2d6d7cbd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.