Closed
Bug 801819
Opened 12 years ago
Closed 12 years ago
Remove nsIDOMCSS2Properties and CSS declaration classinfo bits
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
57.70 KB,
patch
|
dbaron
:
review+
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #671658 -
Flags: review?(peterv)
Attachment #671658 -
Flags: review?(dbaron)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [need review]
Comment on attachment 671658 [details] [diff] [review]
Unpref the CSSStyleDeclaration binding.
r=dbaron
Please merge with bug 115199 if it lands first or describe the necessary merging there if it doesn't.
Attachment #671658 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Thanks for pointing that out. Looks like the merge should be a no-op, actually, at first glance. I'll double-check once Peter reviews.
I thought there would be some additional removals since that patch clones CSSFontFaceStyleDecl for another declaration implementation.
Assignee | ||
Comment 5•12 years ago
|
||
It doesn't clone it correctly (leaves out the classinfo, which is the part this bug is removing), but the incorrectness only matters if this pref is flipped.
Comment 6•12 years ago
|
||
Comment on attachment 671658 [details] [diff] [review]
Unpref the CSSStyleDeclaration binding.
Review of attachment 671658 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/doc/adding-style-props.html
@@ +458,2 @@
> <a href="#CSSPropList">add your property</a> to <a href="http://lxr.mozilla.org/seamonkey/source/content/shared/public/nsCSSPropList.h">
> +nsCSSPropList.h</a>.
Trailing whitespace.
Attachment #671658 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Looks like this actually got unpreffed in bug 801083.
Summary: Unpref CSSStyleDeclaration binding → Remove nsIDOMCSS2Properties and CSS declaration classinfo bits
Assignee | ||
Comment 8•12 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla19
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•