801159 - implement open in browser for bookmarks

Status: RESOLVED INVALID

(Firefox for Metro Graveyard :: Bookmarks, defect)

Comment 1

[Asa Dotzler [:asa]]

I'm not clear on which feature this maps to.

Comment 2

[Asa Dotzler [:asa]]

I think this is for "bookmarks"

Comment 3

[Matt Brubeck (:mbrubeck)]

Clicking/tapping on a bookmark on the start page opens it in the browser (Bug 791041).  For this bug we need to add the same behavior when clicking/tapping bookmarks in the bookmark manager.

It would also be cool and metro-like if we could select multiple bookmarks and have a button to "open in new tabs" in the app bar.  (We can file a separate bug for that if UX agrees.)

Comment 4

[Sam Foster [:sfoster] (he/him)]

This looks to be already hooked up, but something that I don't understand is preventing the page from opening. The list on the start page uses a BookmarksView with the richgrid element, the Bookmarks panel also uses a BookmarksView with its richgrid element. 

Clicking on items on the start-bookmarks-grid goes through BookmarksView's handleItemClick -> Browser.loadURI(url) -> browser.loadURIWithFlags(...) and the page loads as expected. The same action on the bookmarks-list looks to pass sensible input to browser.loadURIWithFlags but is not successful. 

I get output: 
WARNING: NS_ENSURE_SUCCESS(rv, true) failed with result 0x8000FFFF: file c:/dev/
elm/docshell/base/nsDocShell.cpp, line 10317

..but I'm not sure this is relevant

Comment 5

[Asa Dotzler [:asa]]

context menus for start page tiles is moved to v2.

Comment 6

[Jim Mathies [:jimm]]

general->bookmarks, 6 bugs

Comment 7

[Jim Mathies [:jimm]]

bookmark view was removed.