Closed Bug 801159 Opened 9 years ago Closed 8 years ago

implement open in browser for bookmarks


(Firefox for Metro Graveyard :: Bookmarks, defect)

Windows 8.1
Not set


(Not tracked)



(Reporter: ally, Unassigned)



No description provided.
OS: Mac OS X → Windows 8 Metro
I'm not clear on which feature this maps to.
I think this is for "bookmarks"
Summary: implement open in browser for browswe → implement open in browser for bookmarks
Clicking/tapping on a bookmark on the start page opens it in the browser (Bug 791041).  For this bug we need to add the same behavior when clicking/tapping bookmarks in the bookmark manager.

It would also be cool and metro-like if we could select multiple bookmarks and have a button to "open in new tabs" in the app bar.  (We can file a separate bug for that if UX agrees.)
Depends on: 791041
Priority: -- → P1
Whiteboard: [metro-mvp] → [metro-mvp][LOE:1]
This looks to be already hooked up, but something that I don't understand is preventing the page from opening. The list on the start page uses a BookmarksView with the richgrid element, the Bookmarks panel also uses a BookmarksView with its richgrid element. 

Clicking on items on the start-bookmarks-grid goes through BookmarksView's handleItemClick -> Browser.loadURI(url) -> browser.loadURIWithFlags(...) and the page loads as expected. The same action on the bookmarks-list looks to pass sensible input to browser.loadURIWithFlags but is not successful. 

I get output: 
WARNING: NS_ENSURE_SUCCESS(rv, true) failed with result 0x8000FFFF: file c:/dev/
elm/docshell/base/nsDocShell.cpp, line 10317

..but I'm not sure this is relevant
Priority: P1 → --
context menus for start page tiles is moved to v2.
No longer blocks: 801150
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp-][LOE:1]
Keywords: feature
Whiteboard: [metro-mvp-][LOE:1]
general->bookmarks, 6 bugs
Component: General → Bookmarks
No longer blocks: metrov2planning
bookmark view was removed.
Closed: 8 years ago
Resolution: --- → INVALID
No longer blocks: 801164, metrobacklog
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.