801281 - (SQLite3.7.14.1) Upgrade to SQLite 3.7.14.1

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #789645 +++

* Fix a bug (ticket [d02e1406a58ea02d]]) that causes a segfault on a LEFT JOIN that includes an OR in the ON clause.
* Work around a bug in the optimizer in the VisualStudio-2012 compiler that causes invalid code to be generated when compiling SQLite on ARM.
* Fix the TCL interface so that the "nullvalue" setting is honored for TCL implementations of SQL functions.

Not sure if this is something we're going to want on Aurora or not, too.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.14.1 - SQLite changes

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.14.1 - Mozilla changes

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=1ecbebd1ce84

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Ryan VanderMeulen from comment #0)
> +++ This bug was initially created as a clone of Bug #789645 +++
> 
> * Fix a bug (ticket [d02e1406a58ea02d]]) that causes a segfault on a LEFT
> JOIN that includes an OR in the ON clause.

I really hope we don't have any, since it's sort of a crazy thing to do.

> * Work around a bug in the optimizer in the VisualStudio-2012 compiler that
> causes invalid code to be generated when compiling SQLite on ARM.

This is just windows on ARM, don't think we need it on Autora, likely not in central as well, until we have something running on a Windows tablet.

> * Fix the TCL interface so that the "nullvalue" setting is honored for TCL
> implementations of SQL functions.

we don't use this.

So no, I don't think we need this on Aurora. We may take it in central just to fix those rare join queries by add-ons.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2289b37c913d
https://hg.mozilla.org/integration/mozilla-inbound/rev/31642ee5a1c9

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2289b37c913d
https://hg.mozilla.org/mozilla-central/rev/31642ee5a1c9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 671078 [details] [diff] [review]
Upgrade to SQLite 3.7.14.1 - SQLite changes

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 789645

User impact if declined:
Possible crash if an addon is using a very poorly designed query.

Testing completed (on m-c, etc.):
On m-c for almost a week.

Risk to taking this patch (and alternatives if risky):
Very minor update from 3.7.14. Not very risky.

String or UUID changes made by this patch:
None

Comment 8

[bhavana bajaj [:bajaj]]

CCing Jorge, to check if regression/issues on the add-ons side would be easy to find if we take this patch considering the user impact in comment 7 ?

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

you should search for queries containing a "LEFT JOIN table ON some_condition OR some_other_condition"

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to bhavana bajaj [:bajaj] from comment #8)
> CCing Jorge, to check if regression/issues on the add-ons side would be easy
> to find if we take this patch considering the user impact in comment 7 ?

I can't find any add-ons on AMO that use a LEFT JOIN with an OR in the ON clause. Unless there's a major non-AMO add-on doing this, I don't expect this to have any noticeable user impact.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3985eab2ddec
https://hg.mozilla.org/releases/mozilla-aurora/rev/e5053ea5b2ee