789645 - (SQLite3.7.14) Upgrade to SQLite 3.7.14

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

* Drop built-in support for OS/2. If you need to upgrade an OS/2 application to use this or a later version of SQLite, then add an application-defined VFS using the sqlite3_vfs_register() interface. The code removed in this release can serve as a baseline for the application-defined VFS.
* Ensure that floating point values are preserved exactly when reconstructing a database from the output of the ".dump" command of the command-line shell.
* Added the sqlite3_close_v2() interface.
* Updated the command-line shell so that it can be built using SQLITE_OMIT_FLOATING_POINT and SQLITE_OMIT_AUTOINIT.
* Improvements to the windows makefiles and build processes.
* Enhancements to PRAGMA integrity_check and PRAGMA quick_check so that they can optionally check just a single attached database instead of all attached databases.
* Enhancements to WAL mode processing that ensure that at least one valid read-mark is available at all times, so that read-only processes can always read the database.
* Performance enhancements in the sorter used by ORDER BY and CREATE INDEX.
* Added the SQLITE_DISABLE_FTS4_DEFERRED compile-time option.
* Better handling of aggregate queries where the aggregate functions are contained within subqueries.
* Enhance the query planner so that it will try to use a covering index on queries that make use of or optimization.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=1263022d0773

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.14 - SQLite changes

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.14 - Mozilla changes

Comment 4

[Marco Bonardo [:mak]]

hm, I wonder what's our current story about OS/2, I know we don't support it as a tier platform, though we have various bugs filed on it and some of those also have 2012 comments.
That is likely not blocking us, but would be cool to figure out who to notify, tentatively trying with Dave Yeo who looks active on OS/2 bugs and ports, he may know who should be aware of the needed changes.

Comment 5

[Dave Yeo]

(In reply to Marco Bonardo [:mak] from comment #4)
> hm, I wonder what's our current story about OS/2, I know we don't support it
> as a tier platform, though we have various bugs filed on it and some of
> those also have 2012 comments.
> That is likely not blocking us, but would be cool to figure out who to
> notify, tentatively trying with Dave Yeo who looks active on OS/2 bugs and
> ports, he may know who should be aware of the needed changes.

Thanks for the heads up. I usually test new releases of sqlite but got sidetracked on this one. I'll pursue on sqlite-dev though it looks like we'll have to add the code back in the form of a VFS.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Dave Yeo from comment #5)
> Thanks for the heads up. I usually test new releases of sqlite but got
> sidetracked on this one. I'll pursue on sqlite-dev though it looks like
> we'll have to add the code back in the form of a VFS.

Yes that's what looks like, would be no problem to add an ifdef vfs fwiw, but I don't think we have resources to achieve it internally.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

do we need to wait for OS/2 support before we can land on m-c?

Comment 8

[Marco Bonardo [:mak]]

no, we don't wait for anything that is not a tier1 platform, I just wanted to figure out who to notify and looks like I was lucky. I will review shortly.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 659435 [details] [diff] [review]
Upgrade to SQLite 3.7.14 - SQLite changes

Review of attachment 659435 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #1)
> https://tbpl.mozilla.org/?tree=Try&rev=1263022d0773

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f78f5160032d
https://hg.mozilla.org/integration/mozilla-inbound/rev/2da9d60d39f1

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f78f5160032d
https://hg.mozilla.org/mozilla-central/rev/2da9d60d39f1

Comment 12

[Marco Bonardo [:mak]]

Nice, I just want to thank you for keeping up with versions.