801532 - [system] Refactor/Cleanup building block in system app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Building block is used a lot in system app, but is in a mess now.
The work need to do:

1. Add these to apps/system/index.html:
   /shared/style/action_menu.css
   /shared/style/confirm.css
   /shared/style/status.css

2. Remove/Delete these outdates css:
   style/modal_dialog/prompt.css
   style/themes/default/core.css
   style/themes/default/menus.css
   style/themes/default/buttons.css
   style/themes/default/banner.css

3. Adjust the DOM and then make sure modal dialog works.

4. Adjust the DOM and then make sure authentication dialog works.

5. Adjust the DOM and then make sure system banner works.

6. Adjust the DOM and then make sure permission dialog works.

7. Adjust the DOM and then make sure list menu works.
7.1 Make sure contextmenu works
7.2 Make sure activitymenu works

8. Make sure value selector still works.

Attention:

1. per @kaze, the value selector itself would not be container in the shared dir.
1.1 But it still conflicts with current shared bb styles!
2. add `onsubmit="return:false"` to all `form` element.

Comment 1

[Ben Francis [:benfrancis]]

The policy for building block work is now that it's set basecamp-blocking- and requires driver approval to get landed.

With regards to this particular issue QA have asked if they can spend some time testing any patches before they land because they're in the system app.

Comment 2

[Ismael Gonzalez [:basiclines]]

I think we should try to add in shared/style/ value_selector.css , date_picker and time_picker as it was the inital approach. Even is is only used in the system application.

This will give us more freedom/control to update it and will allow easiest/unified customizations for OEM as other similar bb belongs to shared folder.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

I recommend to open a bug for "Move value selector-liked bb out of system app", and mark the dependency on this bug.

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Alive, make sense moving them out to shared/style, as it will be easier to customise the skin, or add app specific needs.

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Alive Kuo [:alive] from comment #3)
> I recommend to open a bug for "Move value selector-liked bb out of system
> app", and mark the dependency on this bug.

Alive, I just filed bug 870747 according to your suggestion.

Comment 6

[BMO Automation]

Firefox OS is not being worked on