870747 - Move value selector BB files out of system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

The value selector building blocks (cf. https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Value_Selector) are decentralized across different apps, their main iteration being located in the System app.

The following should be moved to shared/style and apps depending on this updated:
apps/system/style/value_selector/*
apps/system/style/bb/ (which also includes date_picker and time_picker)

On a high level search through apps, copies of value_selector.css reside in (Note: this list might be incomplete):
apps/bluetooth/style/bb/value_selector.css
apps/email/style/value_selector.css
** apps/system/style/bb/value_selector.css
** apps/system/style/value_selector/value_selector.css

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

It seems that value selector also has some js code in apps/system/js/value_selector/, I suppose this would also need to be moved to shared/

Comment 2

[Ismael Gonzalez [:basiclines]]

I think the only needed files to be shared are just the .css files.
value_selector .js files should be keept in system folder as the .css are officially BUilding Blocks

Comment 3

[Ismael Gonzalez [:basiclines]]

Attachment: PR

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Have you manually tested all the dialog to see if it works still?

Comment 5

[Ismael Gonzalez [:basiclines]]

Sure, i've tested all value pickers (time, date and value) manually from calendar app and from ui test app all the confirm/dialogs/pickers available.
I don't know if there is other ones to manually test from other applications.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 788882 [details]
PR

Thanks!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 788882 [details]
PR

r=me, thanks.

Comment 8

[Ismael Gonzalez [:basiclines]]

Merged in master => https://github.com/mozilla-b2g/gaia/commit/486a1a2845874c7050dcb98c1887a5305f7a0d05