801671 - [AccessFu] Regression in visual tracking

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Spun off bug 800905 comment #2:
)
> I noticed a few other regressions when writing this. Most prominent tab
> switching and the visual highlight not moving with the scroll.

Filing this as a separate bug to deal with these issues.

Comment 1

[Eitan Isaacson [:eeejay]]

Tab switching never really worked right, so I am going to change the summary to reflect the real regression. I'll submit a patch for tab switching and generally focus niceties in a separate bug.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Don't use cached bounds after scrolling, they use the previous scroll position.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 672093 [details] [diff] [review]
Don't use cached bounds after scrolling, they use the previous scroll position.

Review of attachment 672093 [details] [diff] [review]:
-----------------------------------------------------------------

OK r=me. It took me a while to realize the visual presenter doesn't care about context beyond the accessible.

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ea9b548002

Comment 5

[Eitan Isaacson [:eeejay]]

This should land in Aurora as well.

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 672093 [details] [diff] [review]
Don't use cached bounds after scrolling, they use the previous scroll position.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Regression from a refactor having to do with B2G multi-process accessibility work.
User impact if declined: Viual indication of where the accessibility focus is would be broken.
Testing completed (on m-c, etc.): Yes, on a local build made from Inbound.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7ea9b548002

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/59b71be6285e