801693 - Camera - video recording - need to plumb video recorder error-handling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

This is likely related to the work required for bug 795090, but filing it separately and explicitly here.

The hook is to pass a suitable Listener-derived object into setListener().

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add support for onRecorderStateChange

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Sample camera.js patch to illustrate recorder error handling

:dale, how's this for an error handler?  Any thoughts on what kind of errors you want to get or even how specific they are?

It seems that in some cases, recovery is just restarting the preview, but I'm still trying to come up with a way of reliably triggering errors.

Comment 3

[Dale Harvey (:daleharvey)]

We will likely want to have 'time remaining' notifications, as well as when the recording is force stopped due to out of space. I cant think of many other expected errors.

Just in terms of nitting the api I would expect these to be an eventListener which would conform to the usual eventlistener semantics (addEventListener / remove etc), but that isnt a big deal for me.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Dale Harvey (:daleharvey) from comment #3)
> We will likely want to have 'time remaining' notifications, as well as when
> the recording is force stopped due to out of space. I cant think of many
> other expected errors.

Time remaining notifications?

Other errors: this may happen if the uSD card fails for some reason, or the recorder runs out of memory, or who knows what.

> Just in terms of nitting the api I would expect these to be an eventListener
> which would conform to the usual eventlistener semantics (addEventListener /
> remove etc), but that isnt a big deal for me.

Agreed.  I'm still learning how to do that, and will update all of the onX event handlers.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add support for onRecorderStateChange

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=881cf3083dbb

jst, do you have time for one more review?

dale, the messages this change will kick out to you include:
- FileSizeLimitReached and VideoLengthLimitReached
- TrackCompleted (two of these will accompany the above messages, or any time the recorder is stopped: one for the audio track, one for the video)
- MediaRecorderFailed, MediaServerFailed, and TrackFailed

I think they're pretty self-describing; when you receive one, the preview will freeze--just call stopRecording() and the preview will resume.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 677517 [details] [diff] [review]
Add support for onRecorderStateChange

Looks good!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9835e1e6be8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9835e1e6be8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b110c18131fb