801716 - Thunderbird Permanent Orange: TEST-UNEXPECTED-FAIL | test_removeDataFromDomain.js | false == true

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mark Banner (:standard8)]

Since these were moved to toolkit, we've been seeing permanent test failures:

TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js | false == true - See following stack:
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: do_throw :: line 451
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: _do_check_eq :: line 545
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: do_check_eq :: line 566
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: do_check_true :: line 580
JS frame :: c:/talos-slave/test/build/xpcshell/tests/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js :: check_visited :: line 76
JS frame :: c:/talos-slave/test/build/xpcshell/tests/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js :: add_visit :: line 62
JS frame :: c:/talos-slave/test/build/xpcshell/tests/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js :: test_history_cleared_with_direct_match :: line 318
JS frame :: c:/talos-slave/test/build/xpcshell/tests/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js :: run_test :: line 628
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: _execute_test :: line 315
JS frame :: -e :: <TOP_LEVEL> :: line 1
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

I think this is due to Thunderbird disabling places by default, I've got a fix in progress that I think should fix it for all tests.

Comment 1

[Mark Banner (:standard8)]

For us this was a regression caused by bug 799229 moving the test to toolkit.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Simple solution of just ensuring that places history is enabled.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/226cb9228a9e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/226cb9228a9e

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 671745 [details] [diff] [review]
The fix

[Approval Request Comment]
This is regression caused by bug 799229 ; if bug 799229 is approved, this one needs to go with it.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 671745 [details] [diff] [review]
The fix

approving since bug 799229 was approved.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ecd0cc752af5