Closed Bug 801874 Opened 7 years ago Closed 7 years ago

Opening a minimized chat is broken

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86_64
Windows 7
defect
Not set

Tracking

(firefox17+ verified, firefox18+ verified)

VERIFIED FIXED
Firefox 19
Tracking Status
firefox17 + verified
firefox18 + verified

People

(Reporter: Felipe, Assigned: Felipe)

Details

(Whiteboard: [Fx17])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
When opening a chat window with the minimized option set to true, we set chatbox.minimized = true here: http://hg.mozilla.org/mozilla-central/annotate/cd3270dc35cc/browser/base/content/socialchat.xml#l328

However, this happens before we insert the element to the DOM, so the minimized getter/setter from the binding is not triggered, and this ends up as a simple property assignment. Also, since the property is defined, the binding doesn't overwrite it, so the toggle() function that changes cb.minimized doesn't work in this case.

By setting it afterwards the problem is fixed, and also the isActive property of that chat gets properly set. Note though that the socialFrameHide event will also be dispatched, so there's a change in behavior with this patch (which could be avoided if done in a different manner, but that sounds like the right behavior, so I'll let others chime in)
Attachment #671609 - Flags: review?(mixedpuppy)
Couldn't you just set the attribute instead? That way the panel opens as minimized, rather than opening normally and then being minimized.
Yeah, that's what I was thinking as the alternate approach. Do you think it's better that way? The only problem of not using the setter is getting it out of sync with this opening code if we add more things to setter later. But that is likely not a problem as whoever writes the code will search for "minimized" and find this in the same file.
Attached patch Patch v2Splinter Review
approach suggested by gavin. Turns out setting isActive and dispatching socialFrameHide will happen anyways due to the DOMContentLoaded handler
Attachment #671616 - Flags: review?
Comment on attachment 671616 [details] [diff] [review]
Patch v2

Yeah, I think it's unlikely that we'll make the "minimized" setter any more complicated, and if we do we'll likely take this into account since it's hard to miss.
Attachment #671616 - Flags: review? → review+
ok cool, i'm adding a test in a moment and another one might need to be changed
Attachment #671609 - Attachment is obsolete: true
Attachment #671609 - Flags: review?(mixedpuppy)
added a check for this in the existing chatwindow test. Other parts of the test did not need to be updated

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc55531de631
https://hg.mozilla.org/mozilla-central/rev/cc55531de631
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Whiteboard: [Fx17]
Comment on attachment 671616 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature, part of Social API
User impact if declined: chats automatically opened by the worker will open full size and can't be minimized
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very small on Firefox's side, but the provider needs to fix an issue that their chat layout is broken when open as minimized.
(If we do not take this patch we should take at least an alternate patch on the branches that allows chats to still be opened as full size but fix the fact that they can't be minimized)

String or UUID changes made by this patch: none
Attachment #671616 - Flags: approval-mozilla-beta?
Attachment #671616 - Flags: approval-mozilla-aurora?
Flags: in-testsuite+
Comment on attachment 671616 [details] [diff] [review]
Patch v2

a=me
Attachment #671616 - Flags: approval-mozilla-beta?
Attachment #671616 - Flags: approval-mozilla-beta+
Attachment #671616 - Flags: approval-mozilla-aurora?
Attachment #671616 - Flags: approval-mozilla-aurora+
Marking verified fixed since this landed with tests. Please add verifyme keyword if there's something you need QA to test.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.