801895 - [Sounds] Update Boot Sound

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P3)

Comment 1

[Patryk Adamczyk [:patryk] UX]

Attachment: System Sounds

Comment 2

[Patryk Adamczyk [:patryk] UX]

Can you please updated the lock and boot sounds with the attached, also update the naming convention. 

Boot Up: The sound should start only on hard boot / restart, not on resume from sleep. The sound should play as soon as the lock screen loads.
Shut Down: Should play as shut down is initiated
Unlock: Should play as the device unlocks
Lock: Should play as the device locks.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Got it. My dish is full so anyone interested please steal this.

Comment 4

[Mike Connor [:mconnor]]

Per b2g-drivers, no feature/polish work will be marked as blocking, and will require driver approval to land.  Marking as blocking-, please get approval from Vivien before landing.

Comment 5

[Ben Francis [:benfrancis]]

+gal

;)

Comment 6

[Patryk Adamczyk [:patryk] UX]

Separated this into 2 bugs. One for boot and 818216 for unlock.

Comment 7

[Patryk Adamczyk [:patryk] UX]

Attachment: system boot sound

Comment 8

[Patryk Adamczyk [:patryk] UX]

Attachment: Approved Boot Sound

This sound play as the lock screen is being drawn. It should only play at hard boot (battery pull, reboot). It should not play when device is coming out of sleep mode / power savings (screen off) mode.

Comment 9

[Sam Joch [:samjoch]]

Attachment: patch

Comment 10

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #9)
> Created attachment 702789 [details]
> patch

Hi Sam, what's happening with this bug?  I tested on the latest gaia/master build (with a hard boot) but wasn't able to hear the boot up sound.  Let me know if I'm testing this wrong. Thanks!

Comment 11

[Sam Joch [:samjoch]]

Attachment: Branch on github

Comment 12

[Sam Joch [:samjoch]]

There is a problem with the attachment sound, when i test with the unlock.ogg (already in gaia) it works but with that file it frozes and wait for the sound to load. can you check that file ?

Comment 13

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #12)
> There is a problem with the attachment sound, when i test with the
> unlock.ogg (already in gaia) it works but with that file it frozes and wait
> for the sound to load. can you check that file ?

I can't see anything wrong with the sound file.  Patryk, can you reattach?  Maybe something we can't see is wrong with the current .ogg attached.  Thanks!

Comment 14

[Patryk Adamczyk [:patryk] UX]

I sent the latest files to Sam. Sam do you have everything you need now?

Comment 15

[Sam Joch [:samjoch]]

Attachment: Branch on github

Comment 16

[Sam Joch [:samjoch]]

Patryk: I added to sound right after ftu and at bootup.

Comment 17

[Sam Joch [:samjoch]]

Attachment: PR Github Gaia

Comment 18

[Sam Joch [:samjoch]]

Patryk: I updated my branch, i changed so that the sound is playing right after the animation of the logo. Let me know ;-)

Comment 19

[Patryk Adamczyk [:patryk] UX]

Its better… (May 02)
Currently it appears to play when the splash screen is fading…
Can we make it make it play after the splash screen has faded? Like .5 of a second later. Or do we not have that fine of a control?

I do like this better than what we have before.

Lets work on this Monday morning, I think we're very close, no reason we can't close this issue.

Comment 20

[Sam Joch [:samjoch]]

Comment on attachment 742228 [details]
PR Github Gaia

Ok i updated the branch/pr, and let 1550ms before the sound is played at bootup.

Comment 21

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 742228 [details]
PR Github Gaia

It starts a bit too early, it should start immediately when you see the first orange circle.

Comment 22

[Sam Joch [:samjoch]]

Patryk: According to the latest version of the branch can i request a review ?

Comment 23

[Patryk Adamczyk [:patryk] UX]

(In reply to Sam Joch [:samjoch] from comment #22)
> Patryk: According to the latest version of the branch can i request a review
> ?

Yes.

Comment 24

[Sam Joch [:samjoch]]

Any news ?

Comment 25

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 742228 [details]
PR Github Gaia

Apologies for missing out this review. Redirecting since Alive knows window manager better than I do.

Comment 26

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 742228 [details]
PR Github Gaia

r- for
1. Lots of lint errors
2. Please consider to have a new module for this.
This doesn't need to live in window manager. (is this code managing any window? No.)
ex: boot_sound.js or sth else.

Thanks!

Comment 27

[Sam Joch [:samjoch]]

Comment on attachment 742228 [details]
PR Github Gaia

I have updated the PR.
I created a new file boot_sound.js and fix the lint error.

Comment 28

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 742228 [details]
PR Github Gaia

Nice, r=me!

Comment 29

[Sam Joch [:samjoch]]

Thanks!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/0ec2a2558cf41da4a2bf52bf6a550e5e2293602c

Comment 30

[Nicolas B. Pierron [:nbp]]

I got an awful surprised a few minutes ago when the phone got flashed again, so I've learn my lessons and did:

$ curl -o ~/silent.ogg http://blog.ginzburgconsulting.com/wp-content/uploads/2013/02/silent.ogg

and every time the repository is automatically updated the script runs:

$ cd B2G_DIR/gaia
$ git reset --hard
$ cd B2G_DIR
$ ./repo sync
$ find $B2G_DIR/gaia -name \*.ogg | xargs -n 1 cp ~/silent.ogg

So as long as nothing depends on the duration on the sounds, this should be fine.

Comment 31

[Andreas Gal :gal]

Patryk, please silence the boot sound until this is ready for prime time and the blocking bugs are fixed. Using silent.ogg is a good temporary fix until we have all the UX and everything in place.

Comment 32

[Sam Joch [:samjoch]]

Revert from #883090:
https://github.com/mozilla-b2g/gaia/commit/586529fb54eae68e7854509b43fd87080cfcc606