Crash reports information page for "What's in a crash report?" and "Learn More" links

VERIFIED FIXED in B2G C1 (to 19nov)

Status

P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: lco, Assigned: Margaret)

Tracking

({feature, l12y})

unspecified
B2G C1 (to 19nov)
feature, l12y
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
See pg. 9 of the spec: http://people.mozilla.com/~lco/Crash_Reporting_B2G/

The user can access more information about what a crash report contains and what Mozilla does with a crash report from two places:
1. The Crash Reporting Prompt (link label is "What's in a crash report?"
2. The "Improve Firefox OS" Settings Page (link label is "Learn More")
(Reporter)

Comment 1

6 years ago
Alina/Tom, are you guys the people to ping about writing the contents of this dialog? If you aren't, who is?

Updated

6 years ago
Blocks: 761905

Comment 2

6 years ago
Tom - Thanks for working on this. 

Larissa - When we chatted yesterday, you mentioned the work was just starting on crash reporting, so if a draft of the copy is sent to you early next week, would that work for you?
(Reporter)

Comment 3

6 years ago
(In reply to Alina Hua from comment #2)

> Larissa - When we chatted yesterday, you mentioned the work was just
> starting on crash reporting, so if a draft of the copy is sent to you early
> next week, would that work for you?

I think this is ok. Thanks for working on this, Tom!
(Assignee)

Comment 4

6 years ago
Clarifying the summary of this bug.

The "What's in a crash report?" link will be in the crash report dialog.
The "Learn More" link will be in the settings UI.
Summary: As a user, I want to understand what a crash report contains and how Mozilla uses this information, so that I know why Mozilla is asking me whether I want to report a crash → Crash reports information page for "What's in a crash report?" and "Learn More" links
(Assignee)

Comment 5

6 years ago
Checking in to see how progress is coming on this bug. The crash reporter dialog UI landed today, so we'd be ready to implement a page for the "Learn More..." link.

Nominating this for blocking because without it the links in these mockups will do nothing.
blocking-basecamp: --- → ?

Comment 6

6 years ago
New feature work for v1.  Marking as blocking.  

Tom/Alina, do you guys have an update on the text here for the two links?  Thanks.
blocking-basecamp: ? → +
Priority: -- → P1
(Reporter)

Comment 7

6 years ago
Spoke to Tom yesterday, he is on it :)
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 8

6 years ago
Larissa, right now the "Learn More" link for the "Performance Data" pref opens a webpage in the browser. Should we also make this a webpage? Or should we file a bug to change the behavior of the other link? It feels odd that they would behave differently.
(Reporter)

Comment 9

6 years ago
I(In reply to Margaret Leibovic [:margaret] from comment #8)
> Larissa, right now the "Learn More" link for the "Performance Data" pref
> opens a webpage in the browser. Should we also make this a webpage? Or
> should we file a bug to change the behavior of the other link? It feels odd
> that they would behave differently.

I can file a bug for "Learn More" in the "Performance Data" page. That should be an internal site as well since the text is likely not to change very much.
(Assignee)

Comment 10

6 years ago
Making these into local pages was marked as blocking- in bug 807187, so maybe we should just make this into a webpage for now. Is there an existing webpage that we would be able to direct users to, at least for the time being?
Keywords: feature
We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.
Target Milestone: --- → B2G C1 (to 19nov)
(Assignee)

Comment 12

6 years ago
Dietrich and I talked about this, and using a webpage, similarly to how we do in-product links in Firefox would be the most straightforward way to resolve the blocking issue here.

To do this, I'll just need a URL to point these two links to. For desktop/Android, we point users to SUMO kb articles for things like these (e.g. https://support.mozilla.org/en-US/kb/send-performance-data-improve-firefox). Can we do that for b2g?

I still haven't heard back about the actual text for this page, but that could just be included in a kb article. I'd just need to know what URL to use, and the preferred way of doing that in Gaia. Do we need to make it a localized string, or can SUMO magic just redirect to the correct locale?
(Assignee)

Comment 13

6 years ago
Poking this bug, since it's a C1 blocker.

Still need strings here, or a link to a SUMO kb article (preferred method).

mluna, is there a SUMO base URL for Firefox OS? If so, I can just make up a URL to a kb article, similarly to how we did for telemetry "Learn More" links for desktop/Android.
(Reporter)

Comment 14

6 years ago
Alina says Tom will provide the string once he gets back from MozFest. Tom, ETA?
Flags: needinfo?(tom)
(Assignee)

Comment 15

6 years ago
(In reply to Margaret Leibovic [:margaret] from comment #13)
> Still need strings here, or a link to a SUMO kb article (preferred method).
> 
> mluna, is there a SUMO base URL for Firefox OS? If so, I can just make up a
> URL to a kb article, similarly to how we did for telemetry "Learn More"
> links for desktop/Android.

Hrm, I just realized that this SUMO link solution won't work for the dialog, since clicking the link requires opening Firefox, but I don't think we can do that from a modal dialog.

(In reply to Larissa Co from comment #14)
> Alina says Tom will provide the string once he gets back from MozFest. Tom,
> ETA?

I'll work on the logic for making a "Crash Reports" page, but I need to know what to put in it by the end of the week.

Cc'ing stas, as this will involve strings if we don't go with the SUMO link approach.
(Assignee)

Comment 16

6 years ago
I started working on a patch for the settings part of this here:
https://github.com/leibovic/gaia/commit/5bf16c8132bce0ca15b5ef49075d21169a4a7461

Kaze, I'm seeing a bunch more of those "Warning: Empty string passed to getElementById()" messages, like in bug 811447. Is there something I'm doing wrong here? Obviously I don't have the real string here, but if you can offer me feedback that would speed up review later! :)
(Assignee)

Comment 17

6 years ago
Here's my current WIP for the crash reports page from the dialog:
https://github.com/leibovic/gaia/commit/04d2617c518797b2128c00cbbcb6c34fad757641

These two pages in settings/system look slightly different, but I feel like that's okay as long as they're consistent within the context where they're shown. Also, they definitely look okay enough for landing to fix this blocker :)

Once I get the final strings I'll finish up these patches and request review!
(Assignee)

Comment 18

6 years ago
Created attachment 682504 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6465

I opened a PR, but I'll wait to get the final strings before flagging for review.
Keywords: l12y
(Assignee)

Updated

6 years ago
Depends on: 813128
(Assignee)

Comment 19

6 years ago
Comment on attachment 682504 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6465

I filed bug 813128 to update the string with the final text, so we can just land this today.
Attachment #682504 - Flags: review?(kaze)
Attachment #682504 - Flags: review?(alive)
Comment on attachment 682504 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6465

Looks good, thanks!
Attachment #682504 - Flags: review?(kaze) → review+
(Assignee)

Updated

6 years ago
Attachment #682504 - Flags: review?(alive)
(Assignee)

Comment 21

6 years ago
https://github.com/mozilla-b2g/gaia/commit/75f0bf4450be8038ff3e98a3cd1db922f023264d

Follow-up strings to come in bug 813128.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Flags: needinfo?(tom)

Comment 22

6 years ago
verified on unagi build id:  20130103070201
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.