update social provider manifest and whitelist

RESOLVED FIXED in Firefox 17

Status

()

Product:
Firefox
Component:
SocialAPI
Status:
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Version:
Trunk
Target:
Firefox 19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17+ fixed, firefox18+ fixed)

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 attachment)

patch
5.70 KB, patch
jaws
: review+
Gavin
: approval-mozilla-aurora+
Gavin
: approval-mozilla-beta+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
We're switching the default Social provider from MoTown. This will involve:
- updating the default manifest, including favicon image as a data URI (social.manifest.motown->social.manifest.facebook)
- updating the activation whitelist (social.activation.whitelist)
- updating browser/base/content/social-icon.png to be the proper size/image
(Assignee)

Comment 1

•
6 years ago 
Created attachment 671679 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #671679 - Flags: review?(mixedpuppy)
Attachment #671679 - Flags: review?(jaws)
Attachment #671679 - Flags: review?(felipc)

Comment 2

•
6 years ago 
Comment on attachment 671679 [details] [diff] [review]
patch

Review of attachment 671679 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I also tested it out locally and the activation popup is showing the correct image.
Attachment #671679 - Flags: review?(mixedpuppy)
Attachment #671679 - Flags: review?(jaws)
Attachment #671679 - Flags: review?(felipc)
Attachment #671679 - Flags: review+
Attachment #671679 - Flags: approval-mozilla-beta+
Attachment #671679 - Flags: approval-mozilla-aurora+

Comment 6

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/b1bbedc3d30e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [Fx17] → [Fx17][qa-]
You need to log in before you can comment on or make changes to this bug.