Closed
Bug 801951
Opened 8 years ago
Closed 8 years ago
update social provider manifest and whitelist
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(firefox17+ fixed, firefox18+ fixed)
RESOLVED
FIXED
Firefox 19
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
(Whiteboard: [Fx17][qa-])
Attachments
(1 file)
5.70 KB,
patch
|
jaws
:
review+
Gavin
:
approval-mozilla-aurora+
Gavin
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We're switching the default Social provider from MoTown. This will involve: - updating the default manifest, including favicon image as a data URI (social.manifest.motown->social.manifest.facebook) - updating the activation whitelist (social.activation.whitelist) - updating browser/base/content/social-icon.png to be the proper size/image
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #671679 -
Flags: review?(mixedpuppy)
Attachment #671679 -
Flags: review?(jaws)
Attachment #671679 -
Flags: review?(felipc)
Comment 2•8 years ago
|
||
Comment on attachment 671679 [details] [diff] [review] patch Review of attachment 671679 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. I also tested it out locally and the activation popup is showing the correct image.
Attachment #671679 -
Flags: review?(mixedpuppy)
Attachment #671679 -
Flags: review?(jaws)
Attachment #671679 -
Flags: review?(felipc)
Attachment #671679 -
Flags: review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1bbedc3d30e
Target Milestone: --- → Firefox 19
Assignee | ||
Updated•8 years ago
|
Attachment #671679 -
Flags: approval-mozilla-beta+
Attachment #671679 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/a6a663ab1bff
status-firefox17:
--- → fixed
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/94851142600f
status-firefox18:
--- → fixed
Comment 6•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1bbedc3d30e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•