Closed Bug 801951 Opened 8 years ago Closed 8 years ago

update social provider manifest and whitelist

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17+ fixed, firefox18+ fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox17 + fixed
firefox18 + fixed

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 file)

patch
5.70 KB, patch
jaws
: review+
Gavin
: approval-mozilla-aurora+
Gavin
: approval-mozilla-beta+
Details | Diff | Splinter Review 
We're switching the default Social provider from MoTown. This will involve:
- updating the default manifest, including favicon image as a data URI (social.manifest.motown->social.manifest.facebook)
- updating the activation whitelist (social.activation.whitelist)
- updating browser/base/content/social-icon.png to be the proper size/image
Attached patch patch — — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #671679 - Flags: review?(mixedpuppy)
Attachment #671679 - Flags: review?(jaws)
Attachment #671679 - Flags: review?(felipc)
Comment on attachment 671679 [details] [diff] [review]
patch

Review of attachment 671679 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I also tested it out locally and the activation popup is showing the correct image.
Attachment #671679 - Flags: review?(mixedpuppy)
Attachment #671679 - Flags: review?(jaws)
Attachment #671679 - Flags: review?(felipc)
Attachment #671679 - Flags: review+
Attachment #671679 - Flags: approval-mozilla-beta+
Attachment #671679 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/b1bbedc3d30e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [Fx17] → [Fx17][qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.