802071 - [l10n] Sometimes, l10n does not get loaded properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[:gerard-majax]

Attachment: Tentative patch to circumvent the issue.

When the system app starts, in its early days, it sometimes seems not being able to find the correct navigator.language value. Hence it defaults to 'en-US' while the rest of the system will be correctly localized. This has been hit on both Nexus S and Otoro. This patch mitigates the issue by forcing re-reading the 'language.current' settings and when receiveing the value, relocalizing the document.

Comment 1

[:gerard-majax]

This was github issue https://github.com/mozilla-b2g/gaia/pull/5071

Comment 2

[Mike Connor [:mconnor]]

Loading in the wrong locale is functionally broken -> Blocking.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 671774 [details] [diff] [review]
Tentative patch to circumvent the issue.

Fabien can you review it?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Alexandre this patch would start Gaia only once the the 2 values has been synced. I'm stealing the bug but feel free to comment!

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c351ccde036

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5c351ccde036

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Part of this made it on to b2g18 somewhere along the way, but it still partially applied.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/10e2a5bad86f

Comment 9

[amiller]

Device: unagi
Build: 20130112070202
Does not reproduce at this time.