802113 - [gallery] typo in photo swipe listener

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

> currentPhotoFrame.style.transition =
>   nextPhotoFrame.style.transition =
>   previousPhotoFrame.style.transition = 'translate ' + time + 'ms ease';
> photoState.swipe = 0;
> photoState.setFramesPosition();

must be:

> previousPhotoFrame.style.transition = 'transform ' + time + 'ms ease';

If the user pans a photo not far enough so that we switch to the previous or next picture, the old position will be restored without a transition.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5841

Pointer to Github pull-request

Comment 2

[David Flanagan [:djf]]

Comment on attachment 671817 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5841

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: no transition where one is expected.
Testing completed:
Risk to taking this patch (and alternatives if risky): no risk; one line patch

Comment 3

[David Flanagan [:djf]]

Tim, I went ahead and set the flag to request approval to land... Then realized I probably should have left that to you.  Still figuring out the process here.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to David Flanagan [:djf] from comment #3)
> Tim, I went ahead and set the flag to request approval to land... Then
> realized I probably should have left that to you.  Still figuring out the
> process here.

I don't really think it matters who requests approval. Thank you!

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/af3de0c6f003914e8074b73bf1a4f8833d294142

Comment 6

[cbarker]

Verified Fixed in Unagi Build 20130102070202