802227 - Add --testvars argument to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Zac needs a way to pass private information into a test, that should not be hardcoded in a test, such as the marketplace credentials.

We could add a --testvars argument that would point to a Python or JSON file containing a dict with values that we'd make available to tests, e.g.,

--testvars mypassword.py contains

test_vars = {
  'user': 'joe',
  'password': 'foobar'
}

A test might use these then like:

def test_something(self):
    element = # find some element
    element.send_keys(self.test_vars['user'])

Comment 1

[David Burns :automatedtester]

Attachment: adding in test vars

Adding in the ability to run tests with --testvars that takes a JSON file. Chose JSON since that way they will be able to manipulate the data as they want and just work with a dictionary to get the data out.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 673264 [details] [diff] [review]
adding in test vars

Review of attachment 673264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Can you also bump the version in setup.py to 0.5, and then after landing this, mirror it to github, and then post the package to pypi?  I'll need to set you as an owner of the pypi package, so msg me your pypi username.

::: testing/marionette/client/marionette/runtests.py
@@ +202,5 @@
> +
> +        if testvars is not None:
> +            if not os.path.exists(testvars):
> +                raise Exception('--testvars file does not exist')
> +            

Can you remove the extra whitespace at the beginning of this line?

Comment 3

[David Burns :automatedtester]

Landed on m-i https://hg.mozilla.org/integration/mozilla-inbound/rev/be7c882f0f85

Comment 4

[David Burns :automatedtester]

landed on github https://github.com/mozilla/marionette_client/commit/e8e27490a9c4c9cebbba50e4ad9a3221c87a96a3

Comment 5

[David Burns :automatedtester]

uploaded to pypi
.
.
.
Writing marionette_client-0.5/setup.cfg
creating dist
Creating tar archive
removing 'marionette_client-0.5' (and everything under it)
running upload
Submitting dist/marionette_client-0.5.tar.gz to http://pypi.python.org/pypi
Server response (200): OK

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be7c882f0f85

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: B2G Marionette Broken

Did you forget to fix MarionetteJSTestCase or something?

Comment 8

[Ed Morley [:emorley]]

This turned marionette red:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=marionette&rev=be7c882f0f85&noignore=1

Comment 9

[David Burns :automatedtester]

patch for this is on bug 803850

Comment 10

[David Burns :automatedtester]

patch in bug 803850 has landed and merged to m-c, closing

Comment 11

[Zac C (:zac)]

IMO JSON is not a good choice for this because it's very sensitive to syntax and you can't put comments into it.

Comment 12

[Zac C (:zac)]

But it does work, thanks

Comment 13

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/projects/ash/rev/e33e555e97bd

Comment 14

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6707e87ab00a