B2G: marionette dies at testing JS cases

RESOLVED FIXED in Firefox 18

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

unspecified
B2G C1 (to 19nov)
ARM
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 673570 [details]
console error message

Bug 802227 add testvar support but didn't fix MarionetteJSTestCase at the same time.
(Assignee)

Comment 1

6 years ago
Created attachment 673572 [details] [diff] [review]
WIP

This patch simply adds the omitted arguement back. I'm not quite sure what should the testvar do, but it just works.
(Assignee)

Updated

6 years ago
Component: DOM: Device Interfaces → Marionette
Product: Core → Testing
(Assignee)

Comment 2

6 years ago
Created attachment 673823 [details] [diff] [review]
sync MarionetteJSTestCase.add_tests_to_suite arguements with others
Attachment #673572 - Attachment is obsolete: true
Attachment #673823 - Flags: review?(dburns)
(Assignee)

Updated

6 years ago
Assignee: dburns → vyang
Comment on attachment 673823 [details] [diff] [review]
sync MarionetteJSTestCase.add_tests_to_suite arguements with others

looks good to me. We can speak to jgriffin if this is needed/wanted for the JS tests
Attachment #673823 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/9c8640b0a486
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [automation-needed-in-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/cda5c1e1b43d
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Whiteboard: [automation-needed-in-aurora]
Target Milestone: mozilla19 → B2G C1 (to 19nov)
You need to log in before you can comment on or make changes to this bug.