802270 - Reuse a11y hover event for a11y focus event

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

On Jellybean, TalkBack listens for hover enter events, and then uses them to put the accessibility focus on the hovered item. Right now we interrogate the js layer for the current a11y focus since we don't distinguish between explore by touch and a11y focus.

Going back to the js layer to re-send the previous hover event as an a11y focus event is an anti-pattern. In this patch we simply cache the event and reuse it as an a11y focus event.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Reuse hover enter events for accessibility focus events.

Comment 2

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8286a2f35ab

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8286a2f35ab

Comment 4

[Marco Zehe (:MarcoZ)]

Verified in the 2012-10-20 nightly build.

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 671944 [details] [diff] [review]
Reuse hover enter events for accessibility focus events.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial implementation proving to be inaccurate when recognizing touch/hover events.
User impact if declined: Irregularly inaccurate accessibility focus and potentially wrong clicks executed by TalkBack.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None. This bug must be taken together with bug 802273.

Comment 6

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/3db7e8ef6ba9