802316 - Opacity not working in code

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Andrew]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/19.0 Firefox/19.0
Build ID: 20121016030544

Steps to reproduce:

In userContent.css opacity not working in this code and because of this not open the contexts menu (about:addons for example):

menupopup, context-menu {
-moz-appearance: none !important;
opacity: 0.96 !important;
background: #f1f4fa !important;
-moz-border-top-colors: #fafafa !important;
-moz-border-bottom-colors: #fafafa !important;
-moz-border-left-colors: #fafafa !important;
-moz-border-right-colors: #fafafa !important;
}

This problem appeared in Fx 18+.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/e6df45a28902
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121007183233
Bad:
http://hg.mozilla.org/mozilla-central/rev/24cf40690042
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121008010834
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e6df45a28902&tochange=24cf40690042

Suspected: Bug 610713
Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/65b95ed309b9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121007175634
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/7c119b50e7aa
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121007183935
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=65b95ed309b9&tochange=7c119b50e7aa

Comment 2

[James]

Attachment: patch

Caused by an apparent conflict between WS_EX_COMPOSITED and WS_EX_LAYERED which opacity uses.

Comment 3

[James]

I noticed I forgot to put the bug number in the patch commit message. Wasn't sure if I should obsolete it and attach a new one. Will that carry the r+ over or will I need to re-request a review?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Don't worry about it. I'll add it when I check the patch in. And no, you don't need to re-request review if all you're changing is the commit message.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4acb36e670

Should this have a test?

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a4acb36e670

Comment 7

[Timothy Nikkel (:tnikkel)]

I asked for aurora approval and landed this on aurora as part of bug 802456.
https://hg.mozilla.org/releases/mozilla-aurora/rev/b100957a878e

Comment 8

[Timothy Nikkel (:tnikkel)]

Had to back out from aurora, as it looks like either this or bug 802456 caused an intermittent orange.
https://hg.mozilla.org/releases/mozilla-aurora/rev/729dda93df1e

Comment 9

[Timothy Nikkel (:tnikkel)]

Repushed to aurora. I don't _think_ it was this bug that caused the orange.
https://hg.mozilla.org/releases/mozilla-aurora/rev/908fdc5e9a2b

Comment 10

[Mihai Morar, (:MihaiMorar)]

Looks to work as expected on FF 18b6 on Win 7 x64.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0 (20121227074833)

Comment 11

[Mihai Morar, (:MihaiMorar)]

Verified Fixed on FF 19b1 too. 

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0(20130109111322)