Closed Bug 802411 Opened 7 years ago Closed 7 years ago

Refactor MediaEngine to use GIPS singletons

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: anant, Assigned: anant)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

A few different bugs can be fixed with the right refactoring.
Attached patch Refactor - v1Splinter Review
Fixes Bug 773646, Bug 779039 and Bug 782191.
Attachment #672082 - Flags: review?(rjesup)
Comment on attachment 672082 [details] [diff] [review]
Refactor - v1

Review of attachment 672082 [details] [diff] [review]:
-----------------------------------------------------------------

Why the commented-out mState's?
Attachment #672082 - Flags: review?(rjesup) → review+
Fixed that in a local version of the patch by removing them entirely, we should be inheriting the parent class' mState instead of overriding it so that IsAvailable() will work correctly.
https://hg.mozilla.org/mozilla-central/rev/74cdc7eda9c5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.