Closed
Bug 802411
Opened 13 years ago
Closed 13 years ago
Refactor MediaEngine to use GIPS singletons
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: anant, Assigned: anant)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
25.74 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
A few different bugs can be fixed with the right refactoring.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #672082 -
Flags: review?(rjesup)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 672082 [details] [diff] [review]
Refactor - v1
Review of attachment 672082 [details] [diff] [review]:
-----------------------------------------------------------------
Why the commented-out mState's?
Attachment #672082 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Fixed that in a local version of the patch by removing them entirely, we should be inheriting the parent class' mState instead of overriding it so that IsAvailable() will work correctly.
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•