802421 - Cannot specify a mic and a camera when audio and video are both requested through gUM in the doorhanger UI

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect)

Description

[Jason Smith [:jsmith]]

The current design of the doorhanger UI in gUM for permissions does not allow you to select a specific camera you want to use and a specific mic you want to use if you have more than one webcam input source and more than one mic input source. We should allow the user to explicitly define exactly which mic and video they intend to use when both audio and video are requested through gUM.

Comment 1

[Jason Smith [:jsmith]]

We need to make sure in this bug that we handle the error case as well if a user specifies a mic, but fails to specify a camera, then an error should be indicated saying that both need to be specified.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Not blocking for preffing on - a "would be nice"

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

To be more clear: being able to select both is a blocker (resetting).  Being able to have two separate dropdowns for mic and camera is a non-blocker, though "would be nice".

Comment 5

[Dão Gottwald [:dao]]

Attachment: WIP patch

Randell, I'm sending getUserMedia:response:allow twice in order to specify a video device and an audio device. Will the back-end handle this? If not, what API should I use?

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Well, not it won't work.  I'm figuring out what's possible.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Probably the best way is to return an array of devices, instead of a single device.  While we could return a device for the single case and an array if it's audio+video, it's probably simpler to always return an array.

Comment 8

[Dão Gottwald [:dao]]

Attachment: WIP patch v2

(In reply to Randell Jesup [:jesup] from comment #7)
> Probably the best way is to return an array of devices, instead of a single
> device.  While we could return a device for the single case and an array if
> it's audio+video, it's probably simpler to always return an array.

done, and filed bug 823453

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

bug 823453 is up for review, and tested with this patch and appears to work, so are we ready to review on this?

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 694407 [details] [diff] [review]
patch

>diff --git a/browser/locales/en-US/chrome/browser/browser.properties b/browser/locales/en-US/chrome/browser/browser.properties

>+# LOCALIZATION NOTE (getUserMedia.shareSelectedDevices.label):
>+# Semi-colon list of plural forms. See:
>+# http://developer.mozilla.org/en/docs/Localization_and_Plurals

It may be worth mentioning that only the "1" and "2" cases need to be handled, but...

>+getUserMedia.shareSelectedDevices.label = Share Selected Device;Share Selected Devices

Using the more generic string all of the time is simpler, but having the button label not match the message text is kind of a UX regression. Are these button string changes really necessary? Why not stick with the existing strings?

Comment 12

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #11)
> Comment on attachment 694407 [details] [diff] [review]
> patch
> 
> >diff --git a/browser/locales/en-US/chrome/browser/browser.properties b/browser/locales/en-US/chrome/browser/browser.properties
> 
> >+# LOCALIZATION NOTE (getUserMedia.shareSelectedDevices.label):
> >+# Semi-colon list of plural forms. See:
> >+# http://developer.mozilla.org/en/docs/Localization_and_Plurals
> 
> It may be worth mentioning that only the "1" and "2" cases need to be
> handled, but...
> 
> >+getUserMedia.shareSelectedDevices.label = Share Selected Device;Share Selected Devices
> 
> Using the more generic string all of the time is simpler, but having the
> button label not match the message text is kind of a UX regression. Are
> these button string changes really necessary? Why not stick with the
> existing strings?

A followup bug to this one would be adding No Video / No Audio options to the dropdowns when both video and audio are requested. It would be strange to have a camera but no mic selected and have the button say "Share Camera and Microphone".

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Ah, I had assumed that we would not handle allowing the user to accept sharing a combination of devices other than what the site requested (and that we would avoid prompting if any of the requested devices were not available). I guess that's not the case?

Comment 14

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #13)
> Ah, I had assumed that we would not handle allowing the user to accept
> sharing a combination of devices other than what the site requested (and
> that we would avoid prompting if any of the requested devices were not
> available). I guess that's not the case?

If both video and audio are requested and either is unavailable, will still show the UI for sharing the other.

Comment 15

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06cdd349042e

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/06cdd349042e

Comment 17

[Jason Smith [:jsmith]]

Verified by trying some combinations with multiple mics and cameras - sanity level looks okay. 1/29 build.