Closed Bug 802458 Opened 11 years ago Closed 11 years ago

image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix
1.93 KB, patch
karlt
: review+
Details | Diff | Splinter Review 
Reporting build warning (in linux debug build):
{
image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized]
}

The line of code flagged by this is:
> 485   if (icon) {
> 486     NS_SUCCEEDED(rv);

That line has no effect and should be removed.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch fix — — Splinter Review 

        Attachment #672132 -
        Flags: review?(karlt)

    
  
Summary: /image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] → image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)

        Attachment #672132 -
        Flags: review?(karlt) → review+

    
  
Blocks: 802490

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/30332bf91baf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

          You need to log in
          before you can comment on or make changes to this bug.