Closed Bug 802458 Opened 7 years ago Closed 7 years ago

image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)

Categories

(Core :: ImageLib, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Reporting build warning (in linux debug build):
{
image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized]
}

The line of code flagged by this is:
> 485   if (icon) {
> 486     NS_SUCCEEDED(rv);

That line has no effect and should be removed.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch fixSplinter Review
Attachment #672132 - Flags: review?(karlt)
Summary: /image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] → image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)
Attachment #672132 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/30332bf91baf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.