image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla19
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Reporting build warning (in linux debug build):
{
image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized]
}

The line of code flagged by this is:
> 485   if (icon) {
> 486     NS_SUCCEEDED(rv);

That line has no effect and should be removed.
(Assignee)

Updated

6 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 672132 [details] [diff] [review]
fix
Attachment #672132 - Flags: review?(karlt)
(Assignee)

Updated

6 years ago
Summary: /image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] → image/decoders/icon/gtk/nsIconChannel.cpp:486:21: warning: ‘rv’ may be used uninitialized in this function [-Wuninitialized] (in #ifdef MOZ_ENABLE_GIO chunk of code)
Attachment #672132 - Flags: review?(karlt) → review+
(Assignee)

Updated

6 years ago
Blocks: 802490

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/30332bf91baf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.