802490 - Mark a bunch of subdirs in /image as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: mark a bunch of Makefiles in /image as FAIL_ON_WARNINGS

These /image subdirectories are fine being marked as FAIL_ON_WARNINGS in my local build (both debug and opt).

CAVEAT: I'm on linux, so I haven't directly tested the image/decoders/icon/mac/Makefile.in tweak yet, but I'm boldly assuming that will be fine, and I'm gonna let TryServer confirm that for me.

BONUS NOTE: We can also hit image/decoders/Makefile.in, too, once bug 744686's patch lands. (That's the last potentially-fatal warning in that directory.)

Comment 1

[Joe Drew (not getting mail)]

Comment on attachment 672183 [details] [diff] [review]
mark a bunch of Makefiles in /image as FAIL_ON_WARNINGS

Review of attachment 672183 [details] [diff] [review]:
-----------------------------------------------------------------

presuming it passes try, r=omgyes

Comment 2

[Daniel Holbert [:dholbert]]

Passed try! (opt + debug builds on all platforms)
  https://tbpl.mozilla.org/?tree=Try&rev=73c3803bd369

(That Try run had a bit extra --  bug 744686's fix and the image/decoders/Makefile.in tweak, per BONUS NOTE in comment 0. I won't be landing those changes here.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df7e936ddfd3

Comment 4

[Jonathan Watt [:jwatt]]

Can this be closed?

Comment 5

[Daniel Holbert [:dholbert]]

Yup -- looks like it was merged to m-c as
  https://hg.mozilla.org/mozilla-central/rev/df7e936ddfd3
but I inverted two numbers in the commit message, so the "pushed to m-c / close-bug" update ended up on bug 802409 instead of this bug.

Closing. (Thanks for noticing that it was still mistakenly open!)