Closed Bug 80280 Opened 24 years ago Closed 3 years ago

Messages in Template folder need "Edit Template" button in header (like for Drafts)

Categories

(SeaMonkey :: MailNews: Composition, enhancement)

Product:
SeaMonkey
Component:
MailNews: Composition
Type:
enhancement
Priority:
Not set
Severity:
minor

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: Peter, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.12)

Attachments

(1 file)

80280-edit-template-button-25312.patch
5.72 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9+) Gecko/20010509 Messages in Template folder need "Edit Template" button in header (like for Drafts)
Keywords: mozilla0.9.1
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: esther → sheelar
Keywords: correctness, ui
adding mail6 keyword because this seems like a *VERY* easy fix - just copy the code from the edit folder (which does have a button) and make minor adjustments.
Keywords: mail6
mail6 is for low risk - high gain bugs. I don't consider this bug being any of those two. please use this keyword sparingly.
Keywords: mail6
Whiteboard: LoRiskHiReward
Correcting: KW:mozilla0.9.9,nsbeta1 / PF/OS:All/All / Sev.:Minor ... To help this bug get some lovin' attention.
Severity: enhancement → minor
Keywords: mozilla0.9.9, nsbeta1
OS: Windows NT → All
Hardware: PC → All
Whiteboard: LoRiskHiReward
Discussed in 2/25 Mail News bug mtg with Engineering Mktng and PjM. Decision was to Future and nsbeta1 minus this bug.
Keywords: nsbeta1 → nsbeta1-
Target Milestone: --- → Future
Product: Browser → Seamonkey
Assignee: sspitzer → mail
Thunderbird bug 380274.
QA Contact: sheelar
Target Milestone: Future → ---
Assignee: mail → nobody
QA Contact: message-display
Assignee: nobody → iannbugzilla
Status: NEW → ASSIGNED
Type: defect → enhancement
Component: MailNews: Message Display → MailNews: Composition

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no Edit Template button on header
Testing completed (on m-c, etc.): 2.53.12
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 2 renames, 2 new strings (new strings can be copied from similar strings without the ellipsis)

Attachment #9267573 - Flags: review?(frgrahl)
Attachment #9267573 - Flags: approval-comm-release?
Attachment #9267573 - Flags: approval-comm-esr60?

Comment on attachment 9267573 [details] [diff] [review]
80280-edit-template-button-25312.patch

LGTM

Given that either Draft or Templete is shown the logic is a bit clumsy but as long as no other 10 boxes show up all good. Alwas room for improvement :)

Attachment #9267573 - Flags: review?(frgrahl)
Attachment #9267573 - Flags: review+
Attachment #9267573 - Flags: approval-comm-release?
Attachment #9267573 - Flags: approval-comm-release+
Attachment #9267573 - Flags: approval-comm-esr60?
Attachment #9267573 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e21af0bbbab1
Messages in Template folder need "Edit Template" button in header (like for Drafts). r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.12
tracking-seamonkey2.53: --- → ?

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e92b0cd76ef7149880aeb558a341fba46c294c8f
Messages in Template folder need "Edit Template" button in header (like for Drafts). r=frg a=frg

status-seamonkey2.53: --- → fixed
tracking-seamonkey2.53: ? → +
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: