803006 - sidebar width not saved at shutdown

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[edA-qa mort-ora-y]

The width of the social sidebar is not being saved when the user exits FireFox. I would expect on reload the sidebar to have the same size it did when I exiting. 

If you open/close the sidebar, or enable/disable the provider, without exiting Firefox it does retain its size.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Add persist="width" attribute

Adds persist="width" to the social-sidebar-box.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db6173f6dd09

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db6173f6dd09

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 673019 [details] [diff] [review]
Add persist="width" attribute

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature - social
User impact if declined: if the sidebar was resized the size is not persisted
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): minimal
String or UUID changes made by this patch: none

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

This has approval for branch uplift, please land asap.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b4db9e158faf
https://hg.mozilla.org/releases/mozilla-beta/rev/d87890ca70ce

Comment 7

[Simona Badau, Desktop QA]

Verified on Firefox 17 beta 5 that - the sidebar width is the same when the user exits Firefox willingly (File menu -> Exit/"x button" or restart) or unexpectedly (by killing Firefox or after a crash).

Verified that the sidebar width is the same after exiting/opening Firefox on Windows 7, Ubuntu 12.04 and Mac OS X 10.8:
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/17.0 Firefox/17.0

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 18 beta 1 - the sidebar width is saved at shutdown.

Verified on Windows 8, Ubuntu 12.04 and Mac OS X 10.7: 
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18.0 Firefox/18.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/18.0 Firefox/18.0

Comment 9

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old