803217 - Simple SDK add-on failing validation with a server error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: The add-on file causing the error

The attached add-on is a fairly small SDK add-on and it doesn't have anything suspicious upon a shallow inspection.

However, when I upload it for validation, it takes a long time to validate, and it finally returns this error:

Your add-on failed validation with 1 error.
Unexpected server error while validating.

Comment 1

[Kris Maglione [:kmag]]

It dies with a memory error. I suppose that's what comes of having an insanely complicated 11K line JS file...

Comment 2

[Matt Basta [:basta]]

Yeah, I just figured out what's causing this.

The SHA1 math can't be done statically without type data, so it just ends up doing string concats, which end up looking like:

[object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object]

...snip about 1.2GB of terminal output...

[object Object][object Object][object Object][object Object][object Object][object Object]


I'm working on a fix now that does better exclusion of dirty objects from binary operations and augmented assignments.

Comment 3

[Matt Basta [:basta]]

Here's the fix (in two parts), pending review:

https://github.com/mattbasta/amo-validator/compare/loadfix

Comment 4

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/c17bc66c3d863dfd313ef1775d45a294b3f280af