803336 - SocialAPI Toolbar button needs 4 pixels of margin in toolbar

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

Currently, the SocialAPI toolbar button is 4 pixels too close to the right side of the Firefox window and 4 pixels too close to the toolbar button on its left.

I'm using OSX and am not sure if this problem occurs in Windows or Linux.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Toolbar at current state and goal state

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I think this is only on OS X.

Comment 3

[edA-qa mort-ora-y]

I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close to the "star" beside it.

Comment 4

[Chris More [:cmore]]

+1 I agree.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: osxfix

I don't have access to linux right now, but this fixes osx.

Comment 6

[Shane Caraveo (:mixedpuppy)]

(In reply to edA-qa mort-ora-y from comment #3)
> I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close
> to the "star" beside it.

Are you talking about the toolbar button, or the recommend button in the url bar?  see bug 803514

Comment 7

[edA-qa mort-ora-y]

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> (In reply to edA-qa mort-ora-y from comment #3)
> > I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close
> > to the "star" beside it.
> Are you talking about the toolbar button, or the recommend button in the url
> bar?  see bug 803514

Oops, yes, I mean the recommend icon in the url bar. The toolbar buttons in Linux look okay (at least to my eyes).

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 674508 [details] [diff] [review]
osxfix

Review of attachment 674508 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +4041,5 @@
>  
>  /* button icon for the service */
>  #social-toolbar-item {
>    -moz-box-orient: horizontal;
> +  margin: 0 4px;

If the margins between buttons changes in the future, then this will get out of date.

I'd rather do the following,

#social-toolbar-item > .toolbarbutton-1:not(:first-child):not(:last-child) {
  margin: 0;
}
#social-toolbar-item > .toolbarbutton-1:first-child {
  -moz-margin-end: 0;
}
#social-toolbar-item > .toolbarbutton-1:last-child {
  -moz-margin-start: 0;
}

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/124486383375

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 675677 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: social api toolbar will be too close to other toolbar buttons on mac os x
Testing completed (on m-c, etc.): locally, just landed on m-i
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

Comment 12

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/124486383375

Comment 13

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05a2f7435773
https://hg.mozilla.org/releases/mozilla-beta/rev/ff48fe4de669

Comment 14

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0
BuildID: 20130206083616

Verified as fixed on Firefox 19 Beta 5 and latest Nightly (BuildID: 20130207030936)