The default bug view has changed. See this FAQ.

SocialAPI Toolbar button needs 4 pixels of margin in toolbar

VERIFIED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
--
major
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: Boriss, Assigned: jaws)

Tracking

Trunk
Firefox 19
All
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed, firefox19 verified)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Currently, the SocialAPI toolbar button is 4 pixels too close to the right side of the Firefox window and 4 pixels too close to the toolbar button on its left.

I'm using OSX and am not sure if this problem occurs in Windows or Linux.
(Reporter)

Comment 1

5 years ago
Created attachment 672999 [details]
Mockup: Toolbar at current state and goal state
I think this is only on OS X.
OS: All → Mac OS X
Hardware: x86_64 → All
Version: unspecified → Trunk

Comment 3

5 years ago
I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close to the "star" beside it.

Comment 4

5 years ago
+1 I agree.
Created attachment 674508 [details] [diff] [review]
osxfix

I don't have access to linux right now, but this fixes osx.
(In reply to edA-qa mort-ora-y from comment #3)
> I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close
> to the "star" beside it.

Are you talking about the toolbar button, or the recommend button in the url bar?  see bug 803514
Assignee: jaws → mixedpuppy
Status: NEW → ASSIGNED

Comment 7

5 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> (In reply to edA-qa mort-ora-y from comment #3)
> > I can confirm that on Linux (Ubunut/KDE 12.04) the icon also looks too close
> > to the "star" beside it.
> Are you talking about the toolbar button, or the recommend button in the url
> bar?  see bug 803514

Oops, yes, I mean the recommend icon in the url bar. The toolbar buttons in Linux look okay (at least to my eyes).
Comment on attachment 674508 [details] [diff] [review]
osxfix

Review of attachment 674508 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +4041,5 @@
>  
>  /* button icon for the service */
>  #social-toolbar-item {
>    -moz-box-orient: horizontal;
> +  margin: 0 4px;

If the margins between buttons changes in the future, then this will get out of date.

I'd rather do the following,

#social-toolbar-item > .toolbarbutton-1:not(:first-child):not(:last-child) {
  margin: 0;
}
#social-toolbar-item > .toolbarbutton-1:first-child {
  -moz-margin-end: 0;
}
#social-toolbar-item > .toolbarbutton-1:last-child {
  -moz-margin-start: 0;
}
Created attachment 675677 [details] [diff] [review]
Patch
Assignee: mixedpuppy → jaws
Attachment #674508 - Attachment is obsolete: true
Attachment #675677 - Flags: review?(felipc)
Attachment #675677 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/124486383375
Flags: in-testsuite-
Whiteboard: [needs-ux] → [qa-]
Comment on attachment 675677 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: social api toolbar will be too close to other toolbar buttons on mac os x
Testing completed (on m-c, etc.): locally, just landed on m-i
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none
Attachment #675677 - Flags: approval-mozilla-beta?
Attachment #675677 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/124486383375
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Attachment #675677 - Flags: approval-mozilla-beta?
Attachment #675677 - Flags: approval-mozilla-beta+
Attachment #675677 - Flags: approval-mozilla-aurora?
Attachment #675677 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/05a2f7435773
https://hg.mozilla.org/releases/mozilla-beta/rev/ff48fe4de669
status-firefox17: --- → fixed
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0
BuildID: 20130206083616

Verified as fixed on Firefox 19 Beta 5 and latest Nightly (BuildID: 20130207030936)
Status: RESOLVED → VERIFIED
status-firefox19: fixed → verified
Summary: SocialAPI Toolbar button needs 4 pixels of padding in toolbar → SocialAPI Toolbar button needs 4 pixels of margin in toolbar
You need to log in before you can comment on or make changes to this bug.