803490 - System Message API: System App fails to receive system messages (follow-up)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Gene Lian (I already quit Mozilla)]

This is a follow-up for fixing Bug 797803 that System App fails to receive system messages. Recently, it doesn't work again because of the check-in of Bug 801257 which did:

  -    if (msg.manifest != this._manifest)
  +    if (msg.manifest != this._manifest || msg.uri != this._uri)

When doing .broadcastMessage():

  this._uri: "app://system.gaiamobile.org/index.html"
  msg.uri: "app://system.gaiamobile.org/"

The page URIs don't match! It seems this issue only happens in System App.

Comment 1

[Gene Lian (I already quit Mozilla)]

This should be a bb+ blocker which blocks Bug 797803.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Hi Fabrice,

This issue is very tricky. When starting up, the app will register all the messages based on the launch_path. When registering handlers, the app will register them based on the current page URI. Therefore, it'd be better to add the correct launch_path for System App so that it won't reject to handle the coming messages.

I think the previous change of matching page URIs is reasonable so I'd prefer keeping it and correcting the manifest part. Please let me know if you don't agree on this change.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 673178 [details]
Patch

I agree that this is a gaia issue.

Comment 4

[Gene Lian (I already quit Mozilla)]

Need help to merge the pull request. Thanks!

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 673178 [details]
Patch

Manifest change only. a=me.