803666 - convert nsDocLoader's outstanding status list to use mozilla::LinkedList

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: convert nsDocLoader's outstanding status list to use mozilla::LinkedList

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 673385 [details] [diff] [review]
convert nsDocLoader's outstanding status list to use mozilla::LinkedList


> protected:
>+    struct nsStatusInfo : public mozilla::LinkedListElement<nsStatusInfo> {
{ should be in the next line.

>+        ~nsStatusInfo()
>+        {
>+            MOZ_COUNT_DTOR(nsStatusInfo);
>+            this->remove();
I assume it is guaranteed 'this' is in the list here.
(As far as I see, that is the case)

>+        }
>+    };
>+
>+    struct nsRequestInfo : public PLDHashEntryHdr
>+    {
>+        nsRequestInfo(const void *key)
Should be const void* aKey, but you're just moving this code so no need to change in
this case (or feel free to change, but change then also the hashtable callback functions).

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9c67b62799b

Comment 4

[Nathan Froyd [:froydnj]]

Re-landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/35dd1e98890d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35dd1e98890d

Comment 6

[Ed Morley [:emorley]]

Unfortunately the inbound push this landed in broke Linux PGO, so push backed out (see bug 809756).

https://hg.mozilla.org/mozilla-central/rev/82c59210f11f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9458ded5789b