803812 - "Restart to Update" button label in about dialog is vague

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[David Balažic]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121010144125

Steps to reproduce:

Open the About dialog (running FF 15.0.1)


Actual results:

Dialog was opened, update to 16.0.1 was downloaded.
Then a button labeled "Restart to Update" appeared in the dialog.


Expected results:

The button label should say "Restart Firefox to update".

I did some other (OS and other apps) updates the same time and realized the vagueness of the button label. The Windows update has also a button saying "Restart now".

So the FF button could be misunderstood as if it would restart the whole computer, not just Firefox.

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

This *is* confusing.  I cringe to think users may be restarting their entire computer over this.  Adding to the backlog.

Comment 4

[YF (Yang)]

I have the two idea.

1. Replace with "Restart &brandShortName; to Update". However, the button width may be too long, especially in Thunderbird, will be unsightly. In addition, the "Update" be initial capital letters are necessary?

2. Add a tooltip to the button, provide limited helpful. e.g. "Restart the Firefox to done update." or "Restart Firefox to done the update", I'm not sure which is correct grammar.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to YF (Yang) from comment #4)
> 1. Replace with "Restart &brandShortName; to Update". However, the button
> width may be too long, especially in Thunderbird, will be unsightly. In
> addition, the "Update" be initial capital letters are necessary?

Let's do this!

Comment 6

[Manish Goregaokar [:manishearth]]

Those looking to solve this bug: Use DXR[1] to find the string in question. "Restart Firefox to Update" seems like a sensible replacements. Use the entity &brandShortName; in place of Firefox since the browser might be named something else.

Let me know if you have any questions.


 [1]: http://dxr.mozilla.org

Comment 7

[Alli (Aria) Grant]

Attachment: 803812-restarttoupdate.patch

This patch should cover it for the main UI, but I noticed there's a different "Restart to Update" in /browser/metro which I'm not sure if needs anything.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8474154 [details] [diff] [review]
803812-restarttoupdate.patch

Review of attachment 8474154 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Alli :)

Firefox for Metro (/browser/metro) isn't being actively developed anymore, so you don't need to worry about changing the string there (though you're welcome to file a separate bug for it if you'd like).

::: browser/locales/en-US/chrome/browser/aboutDialog.dtd
@@ +9,5 @@
>  # the about dialog (see bug 596813 for screenshots).
>  -->
>  <!ENTITY update.checkForUpdatesButton.label       "Check for updates">
>  <!ENTITY update.checkForUpdatesButton.accesskey   "C">
> +<!ENTITY update.updateButton.label                "Restart &brandShortName; to Update">

Unfortunately, whenever we change either the content of a string, or the context where it's used, we need to also change it's ID - otherwise it's too easy for localizers to miss the change and not update the string.

The usual convention in this case is to change the ID to update.updateButton.label2

Comment 9

[Alli (Aria) Grant]

Understandable. Updating the key and where it was used to point to the new key--is there anything else?

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Alli (Aria) Grant from comment #9)
> Understandable. Updating the key and where it was used to point to the new
> key--is there anything else?

That's it!

Comment 11

[Alli (Aria) Grant]

Attachment: 803812-restarttoupdate-2.patch

Round two, since this looks to be the only use.

Comment 12

[Manish Goregaokar [:manishearth]]

Comment on attachment 8474195 [details] [diff] [review]
803812-restarttoupdate-2.patch

Review of attachment 8474195 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

Comment 13

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8474195 [details] [diff] [review]
803812-restarttoupdate-2.patch

Review of attachment 8474195 [details] [diff] [review]:
-----------------------------------------------------------------

Great :)

(Will make this as checkin?, so someone else can land it when they have time.)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8474195 [details] [diff] [review]
803812-restarttoupdate-2.patch

FWIW, checkin-needed plays more nicely with our bug marking tools :)

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a5773f24770

Comment 16

[alex_mayorga]

Verified on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140827030202 CSet: 0753f7b93ab7