Closed Bug 803914 Opened 7 years ago Closed 7 years ago

Port |Bug 791305 Use libjpeg's color conversion code instead of our own| to comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(seamonkey2.16 fixed)

RESOLVED FIXED
Thunderbird 19.0
Tracking Status
seamonkey2.16 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

No description provided.
Attachment #673634 - Flags: review?(bugspam.Callek)
Comment on attachment 673634 [details] [diff] [review]
Use conversion code [Checked in: Comment 4]

Review of attachment 673634 [details] [diff] [review]:
-----------------------------------------------------------------

Approval Request: Worthy of aurora (relevant m-c configure change landed there)

would a+ myself if I technically could
Attachment #673634 - Flags: review?(bugspam.Callek)
Attachment #673634 - Flags: review+
Attachment #673634 - Flags: approval-comm-aurora?
Comment on attachment 673634 [details] [diff] [review]
Use conversion code [Checked in: Comment 4]

I see no reason to backport this. Firstly, m-c's configure will pick up the missing extension, secondly it doesn't actually change anything for the comm-central build and it isn't broken for anyone. So unless I've missed anything, I think it would be an unnecessary backport (we don't generally backport bugs unless they are actually needed to fix an issue).
Attachment #673634 - Flags: approval-comm-aurora? → approval-comm-aurora-
(In reply to Mark Banner (:standard8) from comment #2)
> Comment on attachment 673634 [details] [diff] [review]
> Use conversion code
> 
> I see no reason to backport this. 

I do, but no severe reason, sure. (note that, I didn't know you/TB cared beyond community for aurora anymore, and that SeaMonkey would/should have been in charge of approvals here, outside of the bugzilla limits in place now.)

> Firstly, m-c's configure will pick up the
> missing extension, 

Yes, but here it will allow us to error out much earlier than having to do lots of try compiles/etc.

> secondly it doesn't actually change anything for the
> comm-central build and it isn't broken for anyone.

It shouldn't cause broken behavior by missing in c-c, but it is used by http://mxr.mozilla.org/comm-central/source/config/config.mk#333 when you take into account that the MOZ_JPEG flag there is set dependant on if we use in-tree or native.

> So unless I've missed
> anything, I think it would be an unnecessary backport (we don't generally
> backport bugs unless they are actually needed to fix an issue).

I'd argue that if it makes linux distros trying to compile notice an issue faster, with no risk to breaking anything else, thats a win. Granted I wouldn't backport this to beta if it missed the aurora train, but for aurora I think we have a good low-risk win here.
Comment on attachment 673634 [details] [diff] [review]
Use conversion code [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/2f982f997c22
Attachment #673634 - Attachment description: Use conversion code → Use conversion code [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.